Re: [PATCH 7/7] smm911x: check if the device is ready before using it

[Christian Hemp <c.hemp@phytec.de>]

Hi Jean-Christophe,

there is a issue in your header
“[PATCH 7/7] smm911x: check if the device is ready before using it”
            
I think smc911x is correct.


Christian

Am Mittwoch, den 29.08.2012, 07:06 +0200 schrieb Jean-Christophe
PLAGNIOL-VILLARD:
> poll the READY bit in PMT_CTRL. Any other access to the device is
> forbidden while this bit isn't set. Try for 100ms
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  drivers/net/smc911x.c |   12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
> index cfcd83f..3695d32 100644
> --- a/drivers/net/smc911x.c
> +++ b/drivers/net/smc911x.c
> @@ -422,6 +422,7 @@ static int smc911x_probe(struct device_d *dev)
>  	uint32_t val;
>  	int is_32bit;
>  	struct smc911x_plat *pdata = dev->platform_data;
> +	unsigned int to = 100;
>  
>  	priv = xzalloc(sizeof(*priv));
>  	is_32bit = dev->resource[0].flags & IORESOURCE_MEM_TYPE_MASK;
> @@ -452,6 +453,17 @@ static int smc911x_probe(struct device_d *dev)
>  		}
>  	}
>  
> +	/*
> +	 * poll the READY bit in PMT_CTRL. Any other access to the device is
> +	 * forbidden while this bit isn't set. Try for 100ms
> +	 */
> +	while (!(smc911x_reg_read(priv, PMT_CTRL) & PMT_CTRL_READY) && --to)
> +		udelay(1000);
> +	if (to == 0) {
> +		dev_err(dev, "Device not READY in 100ms aborting\n");
> +		return -ENODEV;
> +	}
> +
>  	val = smc911x_reg_read(priv, BYTE_TEST);
>  	if (val == 0x43218765) {
>  		dev_info(dev, "BYTE_TEST looks swapped, "



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox