From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1T9Bup-0001Lk-Qo for barebox@lists.infradead.org; Wed, 05 Sep 2012 09:28:56 +0000 Message-ID: <1346837333.3388.8.camel@coredoba.hi.pengutronix.de> From: Jan =?ISO-8859-1?Q?L=FCbbe?= Date: Wed, 05 Sep 2012 11:28:53 +0200 In-Reply-To: <20120904084855.GS26594@pengutronix.de> References: <1346672765-16162-1-git-send-email-jlu@pengutronix.de> <1346672765-16162-10-git-send-email-jlu@pengutronix.de> <20120904084855.GS26594@pengutronix.de> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 09/10] omap3: allow enabling clocks for UART3, MMC1 and SPI To: Sascha Hauer Cc: barebox-request On Tue, 2012-09-04 at 10:48 +0200, Sascha Hauer wrote: > On Mon, Sep 03, 2012 at 01:46:04PM +0200, Jan Luebbe wrote: > > Signed-off-by: Jan Luebbe > > --- > > arch/arm/mach-omap/Kconfig | 4 ++++ > > arch/arm/mach-omap/omap3_clock.c | 35 +++++++++++++++++++++++++---------- > > 2 files changed, 29 insertions(+), 10 deletions(-) > > > > diff --git a/arch/arm/mach-omap/Kconfig b/arch/arm/mach-omap/Kconfig > > index a781287..82fa46b 100644 > > --- a/arch/arm/mach-omap/Kconfig > > +++ b/arch/arm/mach-omap/Kconfig > > @@ -61,6 +61,10 @@ config OMAP_CLOCK_UART3 > > bool > > config OMAP_CLOCK_I2C > > bool > > +config OMAP_CLOCK_MMC1 > > + bool > > +config OMAP_CLOCK_SPI > > + bool > > A Kconfig entry for enabling a clock is overkill. Please do not continue > this. > > Right now we have: > > config OMAP_CLOCK_UART > bool > config OMAP_CLOCK_UART2 > bool > config OMAP_CLOCK_UART3 > bool > config OMAP_CLOCK_I2C > bool > > And it's completely unused, so can be simply removed. What should I do instead? Enable all clocks? Or enable just the clocks for which drivers have been enabled in Kconfig? Thanks, Jan -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox