mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Jan Lübbe" <jlu@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 04/12] introduce image_renderer framework
Date: Thu, 06 Sep 2012 12:42:21 +0200	[thread overview]
Message-ID: <1346928141.3775.5.camel@coredoba.hi.pengutronix.de> (raw)
In-Reply-To: <1346911500-12902-4-git-send-email-plagnioj@jcrosoft.com>

Hi!

On Thu, 2012-09-06 at 08:04 +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 93e360b..e74189d 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -38,6 +38,9 @@ config BITREV
>  config QSORT
>  	bool
>  
> +config IMAGE_RENDERER
> +	bool
> +
>  config BMP
>  	bool
>  

> +	enum filetype type = file_detect_type(buf);

You're using functions from common/filetype.c but you do not declare the
dependency on FILETYPE in Kconfig.

Regards,
Jan
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-09-06 10:42 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-06  6:00 [PATCH 00/12] add PNG support Jean-Christophe PLAGNIOL-VILLARD
2012-09-06  6:04 ` [PATCH 01/12] add barebox logo Jean-Christophe PLAGNIOL-VILLARD
2012-09-06  6:04   ` [PATCH 02/12] bmp: rename it to splash Jean-Christophe PLAGNIOL-VILLARD
2012-09-06  6:04   ` [PATCH 03/12] bmp: split bmp rending in lib/bmp.c Jean-Christophe PLAGNIOL-VILLARD
2012-09-06  6:04   ` [PATCH 04/12] introduce image_renderer framework Jean-Christophe PLAGNIOL-VILLARD
2012-09-06 10:42     ` Jan Lübbe [this message]
2012-09-06  6:04   ` [PATCH 05/12] filetype: add BMP support Jean-Christophe PLAGNIOL-VILLARD
2012-09-06  6:04   ` [PATCH 06/12] splash/bmp: switch to image_renderer Jean-Christophe PLAGNIOL-VILLARD
2012-09-06  6:04   ` [PATCH 07/12] splash: add support to set a background color Jean-Christophe PLAGNIOL-VILLARD
2012-09-06  6:04   ` [PATCH 08/12] Introduce graphic utils Jean-Christophe PLAGNIOL-VILLARD
2012-09-06  6:04   ` [PATCH 09/12] graphic_utils: add rgba support Jean-Christophe PLAGNIOL-VILLARD
2012-09-06  6:04   ` [PATCH 10/12] filetype: add PNG support Jean-Christophe PLAGNIOL-VILLARD
2012-09-06  6:04   ` [PATCH 11/12] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-06  6:05   ` [PATCH 12/12] png: add picoPNG lib support Jean-Christophe PLAGNIOL-VILLARD
2012-09-06  8:56     ` Antony Pavlov
2012-09-06 10:37   ` [PATCH 01/12] add barebox logo Jan Lübbe
2012-09-06 10:44     ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-06 12:00       ` Eric Bénard
2012-09-06 12:16   ` Sascha Hauer
2012-09-06  7:37 ` [PATCH 00/12] add PNG support Eric Bénard
2012-09-06  8:55   ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-06  9:10     ` Eric Bénard
2012-09-06  9:47       ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-06  9:55         ` Eric Bénard
2012-09-06 10:03           ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-06 10:12             ` Eric Bénard
2012-09-06 10:29               ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-06 11:59                 ` Eric Bénard
2012-09-06 16:03 ` Sascha Hauer
2012-09-06 21:50   ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-06 22:25     ` Sascha Hauer
2012-09-07  0:18       ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346928141.3775.5.camel@coredoba.hi.pengutronix.de \
    --to=jlu@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox