mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Jan Lübbe" <jlu@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] Add bcm2835/Raspberry-Pi support
Date: Thu, 20 Sep 2012 17:40:06 +0200	[thread overview]
Message-ID: <1348155606.3514.21.camel@coredoba.hi.pengutronix.de> (raw)
In-Reply-To: <1348000210-21686-1-git-send-email-carlo.caione@gmail.com>

Hi,

I've tried your patches and the boot fine:

barebox 2012.09.0-00168-g5a8f45d #1 Thu Sep 20 17:24:48 CEST 2012

Board: RaspberryPi (BCM2835/ARM1176JZF-S)
Malloc space: 0x00200000 -> 0x005fffff (size  4 MB)
Stack space : 0x00100000 -> 0x00108000 (size 32 kB)
Open /dev/env0 No such file or directory
no valid environment found on /dev/env0. Using default environment
running /env/bin/init...
RPi> / devinfo 
devices:
`---- uart-pl0110
     `---- cs0
`---- global
`---- mem0
     `---- 0x00000000-0x07ffffff: /dev/ram0
`---- ramfs0
`---- devfs0
`---- mem1
     `---- 0x00000000-0x00002007: /dev/defaultenv
`---- mem2
     `---- 0x00000000-0xfffffffe: /dev/mem

drivers:
uart-pl011
     ramfs
     devfs
       mem
    cramfs
RPi> / 

The first patch has some white-space warnings which should be fixed:
$ git am ~/\[PATCH_1_2\]_Add_bcm2835_Raspberry-Pi_support.mbox
Applying: Add bcm2835/Raspberry-Pi support
/ptx/work/dude/jlu/raspi/barebox/.git/rebase-apply/patch:358: trailing whitespace.
        .rate = UART0_CLOCK,
/ptx/work/dude/jlu/raspi/barebox/.git/rebase-apply/patch:410: space before tab in indent.
        uint32_t rstc;
/ptx/work/dude/jlu/raspi/barebox/.git/rebase-apply/patch:411: trailing whitespace.

/ptx/work/dude/jlu/raspi/barebox/.git/rebase-apply/patch:415: trailing whitespace.

/ptx/work/dude/jlu/raspi/barebox/.git/rebase-apply/patch:595: trailing whitespace.

warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.

So feel free to add my Tested-By for the cleaned-up version:
Tested-By: Jan Luebbe <jlu@pengutronix.de>

Regards,
Jan
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2012-09-20 15:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18 20:30 Carlo Caione
2012-09-18 20:30 ` [PATCH 2/2] Add Raspberry-Pi defconfig Carlo Caione
2012-09-18 22:07   ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-19 22:19     ` Carlo Caione
2012-09-20  5:19       ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-18 22:06 ` [PATCH 1/2] Add bcm2835/Raspberry-Pi support Jean-Christophe PLAGNIOL-VILLARD
2012-09-19  7:42   ` Juergen Beisert
2012-09-19  8:14     ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-19  8:54       ` Juergen Beisert
2012-09-19  9:37         ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-19  9:10 ` Jan Lübbe
2012-09-19 10:00   ` Carlo Caione
2012-09-19 10:08     ` Jan Lübbe
2012-09-19 10:49       ` Carlo Caione
2012-09-19 10:49       ` Marc Kleine-Budde
2012-09-19 11:10         ` Carlo Caione
2012-09-19 11:13           ` Marc Kleine-Budde
2012-09-20 10:25     ` Thomas Petazzoni
2012-09-20 15:40 ` Jan Lübbe [this message]
2012-09-20 16:18   ` Carlo Caione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348155606.3514.21.camel@coredoba.hi.pengutronix.de \
    --to=jlu@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox