From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: barebox@lists.infradead.org
Subject: [PATCH 3/3] net/eth: fix link handling
Date: Wed, 26 Sep 2012 13:53:31 +0200 [thread overview]
Message-ID: <1348660411-9210-1-git-send-email-plagnioj@jcrosoft.com> (raw)
In-Reply-To: <1348659472-7038-1-git-send-email-plagnioj@jcrosoft.com>
The current code handle just the send where we are supposed to the same on rx
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
net/eth.c | 25 +++++++++++++++----------
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/net/eth.c b/net/eth.c
index d3bda81..402e479 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -124,7 +124,7 @@ int eth_complete(struct string_list *sl, char *instr)
}
#endif
-int eth_send(void *packet, int length)
+int eth_open(void)
{
int ret;
@@ -145,6 +145,17 @@ int eth_send(void *packet, int length)
if (!eth_current->active)
return -ENETDOWN;
+ return 0;
+}
+
+int eth_send(void *packet, int length)
+{
+ int ret;
+
+ ret = eth_open();
+ if (ret)
+ return ret;
+
led_trigger_network(LED_TRIGGER_NET_TX);
return eth_current->send(eth_current, packet, length);
@@ -154,15 +165,9 @@ int eth_rx(void)
{
int ret;
- if (!eth_current)
- return -ENODEV;
-
- if (!eth_current->active) {
- ret = eth_current->open(eth_current);
- if (ret)
- return ret;
- eth_current->active = 1;
- }
+ ret = eth_open();
+ if (ret)
+ return ret;
return eth_current->recv(eth_current);
}
--
1.7.10.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-09-26 11:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 9:31 [PATCH 0/1 v7] net: introduce phylib Jean-Christophe PLAGNIOL-VILLARD
2012-09-24 9:36 ` [PATCH 1/1] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-24 19:20 ` [PATCH 0/1 v7] " Sascha Hauer
2012-09-24 20:14 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-25 17:26 ` Jan Lübbe
2012-09-25 18:19 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 11:02 ` Sascha Hauer
2012-09-26 11:20 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 11:31 ` Sascha Hauer
2012-09-26 11:36 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 11:37 ` [PATCH 1/2] calao: at91 qil/tny/usb auto detect the phy addr Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 11:37 ` [PATCH 2/2] net/eth: fix missing check on eth active Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 11:53 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-09-26 12:43 ` [PATCH 3/3] net/eth: fix link handling Sascha Hauer
2012-09-26 12:50 ` Jan Lübbe
2012-09-26 13:03 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 13:08 ` Sascha Hauer
2012-09-26 13:43 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 13:05 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 13:59 ` [PATCH 1/1] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-26 15:17 ` Sascha Hauer
2012-09-26 15:51 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-02 14:44 ` [PATCH 0/1 v7] net: introduce phylib Renaud Barbier
2012-10-02 16:04 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-02 16:58 ` Sascha Hauer
2012-10-02 18:32 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348660411-9210-1-git-send-email-plagnioj@jcrosoft.com \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox