From: Jan Luebbe <jlu@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 2/2] parameter: support removing named parameters
Date: Wed, 10 Oct 2012 12:42:51 +0200 [thread overview]
Message-ID: <1349865771-18825-2-git-send-email-jlu@pengutronix.de> (raw)
In-Reply-To: <1349865771-18825-1-git-send-email-jlu@pengutronix.de>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
---
include/param.h | 4 ++++
lib/parameter.c | 18 ++++++++++++++++++
2 files changed, 22 insertions(+)
diff --git a/include/param.h b/include/param.h
index e0c415d..21f4f7d 100644
--- a/include/param.h
+++ b/include/param.h
@@ -30,6 +30,8 @@ int dev_add_param(struct device_d *dev, const char *name,
int dev_add_param_fixed(struct device_d *dev, char *name, char *value);
+void dev_remove_param(struct device_d *dev, char *name);
+
void dev_remove_parameters(struct device_d *dev);
int dev_param_set_generic(struct device_d *dev, struct param_d *p,
@@ -67,6 +69,8 @@ static inline int dev_add_param_fixed(struct device_d *dev, char *name, char *va
return 0;
}
+static inline void dev_remove_param(struct device_d *dev, char *name) {}
+
static inline void dev_remove_parameters(struct device_d *dev) {}
static inline int dev_param_set_generic(struct device_d *dev, struct param_d *p,
diff --git a/lib/parameter.c b/lib/parameter.c
index b33ad17..c00b824 100644
--- a/lib/parameter.c
+++ b/lib/parameter.c
@@ -213,6 +213,24 @@ int dev_add_param_fixed(struct device_d *dev, char *name, char *value)
}
/**
+ * dev_remove_param - remove a parameter from a device and free its
+ * memory
+ * @param dev The device
+ * @param name The name of the parameter
+ */
+void dev_remove_param(struct device_d *dev, char *name)
+{
+ struct param_d *p = get_param_by_name(dev, name);
+
+ if (p) {
+ p->set(dev, p, NULL);
+ list_del(&p->list);
+ free(p->name);
+ free(p);
+ }
+}
+
+/**
* dev_remove_parameters - remove all parameters from a device and free their
* memory
* @param dev The device
--
1.7.10.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-10 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 10:42 [PATCH 1/2] parameter: fix memory leak Jan Luebbe
2012-10-10 10:42 ` Jan Luebbe [this message]
2012-10-12 8:03 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349865771-18825-2-git-send-email-jlu@pengutronix.de \
--to=jlu@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox