* [PATCH 1/2] defaultenv-2: Select CMD_ECHO & CMD_ECHO_E by default
@ 2012-10-12 6:50 Alexander Shiyan
2012-10-12 6:50 ` [PATCH 2/2] defaultenv-2: Select CMD_EDIT by default if CMD_MENU_MANAGEMENT is selected Alexander Shiyan
2012-10-12 9:24 ` [PATCH 1/2] defaultenv-2: Select CMD_ECHO & CMD_ECHO_E by default Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 2 replies; 6+ messages in thread
From: Alexander Shiyan @ 2012-10-12 6:50 UTC (permalink / raw)
To: barebox
Command is used in the scripts and it should be compiled in.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
common/Kconfig | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/common/Kconfig b/common/Kconfig
index 9210739..2783405 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -564,6 +564,8 @@ config DEFAULT_ENVIRONMENT_GENERIC_NEW
select CMD_GLOBAL
select CMD_AUTOMOUNT
select CMD_BASENAME
+ select CMD_ECHO
+ select CMD_ECHO_E
select FLEXIBLE_BOOTARGS
prompt "Generic environment template"
--
1.7.3.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] defaultenv-2: Select CMD_EDIT by default if CMD_MENU_MANAGEMENT is selected
2012-10-12 6:50 [PATCH 1/2] defaultenv-2: Select CMD_ECHO & CMD_ECHO_E by default Alexander Shiyan
@ 2012-10-12 6:50 ` Alexander Shiyan
2012-10-12 9:24 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-12 9:24 ` [PATCH 1/2] defaultenv-2: Select CMD_ECHO & CMD_ECHO_E by default Jean-Christophe PLAGNIOL-VILLARD
1 sibling, 1 reply; 6+ messages in thread
From: Alexander Shiyan @ 2012-10-12 6:50 UTC (permalink / raw)
To: barebox
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
commands/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/commands/Kconfig b/commands/Kconfig
index e934f29..89ab2fc 100644
--- a/commands/Kconfig
+++ b/commands/Kconfig
@@ -79,6 +79,7 @@ config CMD_MENU
config CMD_MENU_MANAGEMENT
bool
depends on CMD_MENU
+ select CMD_EDIT
prompt "menu scripts management"
config CMD_LOGIN
--
1.7.3.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] defaultenv-2: Select CMD_ECHO & CMD_ECHO_E by default
2012-10-12 6:50 [PATCH 1/2] defaultenv-2: Select CMD_ECHO & CMD_ECHO_E by default Alexander Shiyan
2012-10-12 6:50 ` [PATCH 2/2] defaultenv-2: Select CMD_EDIT by default if CMD_MENU_MANAGEMENT is selected Alexander Shiyan
@ 2012-10-12 9:24 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-12 11:16 ` Re[2]: " Alexander Shiyan
1 sibling, 1 reply; 6+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-10-12 9:24 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: barebox
On 10:50 Fri 12 Oct , Alexander Shiyan wrote:
> Command is used in the scripts and it should be compiled in.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> common/Kconfig | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/common/Kconfig b/common/Kconfig
> index 9210739..2783405 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -564,6 +564,8 @@ config DEFAULT_ENVIRONMENT_GENERIC_NEW
> select CMD_GLOBAL
> select CMD_AUTOMOUNT
> select CMD_BASENAME
> + select CMD_ECHO
> + select CMD_ECHO_E
ECHO_E need to be optionnal as you may not want the color support
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] defaultenv-2: Select CMD_EDIT by default if CMD_MENU_MANAGEMENT is selected
2012-10-12 6:50 ` [PATCH 2/2] defaultenv-2: Select CMD_EDIT by default if CMD_MENU_MANAGEMENT is selected Alexander Shiyan
@ 2012-10-12 9:24 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 0 replies; 6+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-10-12 9:24 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: barebox
On 10:50 Fri 12 Oct , Alexander Shiyan wrote:
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> commands/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/commands/Kconfig b/commands/Kconfig
> index e934f29..89ab2fc 100644
> --- a/commands/Kconfig
> +++ b/commands/Kconfig
> @@ -79,6 +79,7 @@ config CMD_MENU
> config CMD_MENU_MANAGEMENT
> bool
> depends on CMD_MENU
> + select CMD_EDIT
no cmd_edit have nothing to do with menu
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re[2]: [PATCH 1/2] defaultenv-2: Select CMD_ECHO & CMD_ECHO_E by default
2012-10-12 9:24 ` [PATCH 1/2] defaultenv-2: Select CMD_ECHO & CMD_ECHO_E by default Jean-Christophe PLAGNIOL-VILLARD
@ 2012-10-12 11:16 ` Alexander Shiyan
2012-10-12 11:22 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Shiyan @ 2012-10-12 11:16 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox
Fri, 12 Oct 2012 11:24:08 +0200 от Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>:
> On 10:50 Fri 12 Oct , Alexander Shiyan wrote:
> > Command is used in the scripts and it should be compiled in.
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> > common/Kconfig | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/common/Kconfig b/common/Kconfig
> > index 9210739..2783405 100644
> > --- a/common/Kconfig
> > +++ b/common/Kconfig
> > @@ -564,6 +564,8 @@ config DEFAULT_ENVIRONMENT_GENERIC_NEW
> > select CMD_GLOBAL
> > select CMD_AUTOMOUNT
> > select CMD_BASENAME
> > + select CMD_ECHO
> > + select CMD_ECHO_E
> ECHO_E need to be optionnal as you may not want the color support
For example, command below is not work properly without this option:
echo -e -n "\nHit any key to stop autoboot: "
shows as:
running /env/bin/init...
\nHit any key to stop autoboot: 0
^^
and with CMD_ECHO_E option result is normal:
running /env/bin/init...
Hit any key to stop autoboot: 0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] defaultenv-2: Select CMD_ECHO & CMD_ECHO_E by default
2012-10-12 11:16 ` Re[2]: " Alexander Shiyan
@ 2012-10-12 11:22 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 0 replies; 6+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-10-12 11:22 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: barebox
On 15:16 Fri 12 Oct , Alexander Shiyan wrote:
> Fri, 12 Oct 2012 11:24:08 +0200 от Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>:
> > On 10:50 Fri 12 Oct , Alexander Shiyan wrote:
> > > Command is used in the scripts and it should be compiled in.
> > >
> > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > > ---
> > > common/Kconfig | 2 ++
> > > 1 files changed, 2 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/common/Kconfig b/common/Kconfig
> > > index 9210739..2783405 100644
> > > --- a/common/Kconfig
> > > +++ b/common/Kconfig
> > > @@ -564,6 +564,8 @@ config DEFAULT_ENVIRONMENT_GENERIC_NEW
> > > select CMD_GLOBAL
> > > select CMD_AUTOMOUNT
> > > select CMD_BASENAME
> > > + select CMD_ECHO
> > > + select CMD_ECHO_E
> > ECHO_E need to be optionnal as you may not want the color support
>
> For example, command below is not work properly without this option:
> echo -e -n "\nHit any key to stop autoboot: "
> shows as:
>
> running /env/bin/init...
> \nHit any key to stop autoboot: 0
> ^^
>
> and with CMD_ECHO_E option result is normal:
no -e is ignored if CMD_ECHO_E is not enabled I put this
asn need to be keep that way
so fix hit with an empty echo not by forcing -e
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-12 11:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-12 6:50 [PATCH 1/2] defaultenv-2: Select CMD_ECHO & CMD_ECHO_E by default Alexander Shiyan
2012-10-12 6:50 ` [PATCH 2/2] defaultenv-2: Select CMD_EDIT by default if CMD_MENU_MANAGEMENT is selected Alexander Shiyan
2012-10-12 9:24 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-12 9:24 ` [PATCH 1/2] defaultenv-2: Select CMD_ECHO & CMD_ECHO_E by default Jean-Christophe PLAGNIOL-VILLARD
2012-10-12 11:16 ` Re[2]: " Alexander Shiyan
2012-10-12 11:22 ` Jean-Christophe PLAGNIOL-VILLARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox