From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: barebox@lists.infradead.org
Subject: [PATCH 1/1 v2] gpio: move gpio_is_valid to gpio.h
Date: Sat, 27 Oct 2012 22:22:45 +0200 [thread overview]
Message-ID: <1351369365-21395-1-git-send-email-plagnioj@jcrosoft.com> (raw)
In-Reply-To: <1351368639-20174-1-git-send-email-plagnioj@jcrosoft.com>
gpio < 0 means invalid too
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
send right version
Best Regards,
J.
drivers/gpio/gpio.c | 9 ---------
include/asm-generic/gpio.h | 11 +++++++++++
2 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/gpio/gpio.c b/drivers/gpio/gpio.c
index 6ad8d27..042a062 100644
--- a/drivers/gpio/gpio.c
+++ b/drivers/gpio/gpio.c
@@ -4,17 +4,8 @@
static LIST_HEAD(chip_list);
-#define ARCH_NR_GPIOS 256
-
static struct gpio_chip *gpio_desc[ARCH_NR_GPIOS];
-static int gpio_is_valid(unsigned gpio)
-{
- if (gpio < ARCH_NR_GPIOS)
- return 1;
- return 0;
-}
-
void gpio_set_value(unsigned gpio, int value)
{
struct gpio_chip *chip = gpio_desc[gpio];
diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h
index 1997888..c2e7a5d 100644
--- a/include/asm-generic/gpio.h
+++ b/include/asm-generic/gpio.h
@@ -1,6 +1,17 @@
#ifndef __ASM_GENERIC_GPIO_H
#define __ASM_GENERIC_GPIO_H
+#define ARCH_NR_GPIOS 256
+
+static inline int gpio_is_valid(int gpio)
+{
+ if (gpio < 0)
+ return 0;
+ if (gpio < ARCH_NR_GPIOS)
+ return 1;
+ return 0;
+}
+
void gpio_set_value(unsigned gpio, int value);
int gpio_get_value(unsigned gpio);
int gpio_direction_output(unsigned gpio, int value);
--
1.7.10.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-27 20:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 20:10 [For next PATCH 1/1] " Jean-Christophe PLAGNIOL-VILLARD
2012-10-27 20:22 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-10-29 7:43 ` [PATCH 1/1 v2] " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351369365-21395-1-git-send-email-plagnioj@jcrosoft.com \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox