To: barebox@lists.infradead.org
Subject: [PATCH 1/1] mtd: dataflash: fix spi_transfer init
Date: Thu, 1 Nov 2012 10:16:55 +0100 [thread overview]
Message-ID: <1351761415-3199-1-git-send-email-plagnioj@jcrosoft.com> (raw)
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
on some system as the spi_transfer is not set to 0 if the rx_buf or tx_buf
are not used they are not set to NULL
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
drivers/mtd/devices/mtd_dataflash.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c
index cbed15b..3b7b9c6 100644
--- a/drivers/mtd/devices/mtd_dataflash.c
+++ b/drivers/mtd/devices/mtd_dataflash.c
@@ -161,6 +161,8 @@ static int dataflash_erase(struct mtd_info *mtd, struct erase_info *instr)
spi_message_init(&msg);
+ memset(&x, 0, sizeof(x));
+
x.tx_buf = command = priv->command;
x.len = 4;
spi_message_add_tail(&x, &msg);
@@ -246,6 +248,8 @@ static int dataflash_read(struct mtd_info *mtd, loff_t from, size_t len,
spi_message_init(&msg);
+ memset(&x[0], 0, sizeof(struct spi_transfer) * 2);
+
x[0].tx_buf = command;
x[0].len = 8;
spi_message_add_tail(&x[0], &msg);
@@ -302,6 +306,8 @@ static int dataflash_write(struct mtd_info *mtd, loff_t to, size_t len,
spi_message_init(&msg);
+ memset(&x[0], 0, sizeof(struct spi_transfer) * 2);
+
x[0].tx_buf = command = priv->command;
x[0].len = 4;
spi_message_add_tail(&x[0], &msg);
--
1.7.10.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2012-11-01 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 9:16 [this message]
2012-11-02 8:57 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351761415-3199-1-git-send-email-plagnioj@jcrosoft.com \
--to=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox