* [PATCH 1/1] led-gpio: add bicolor led support
@ 2012-11-16 20:17 Jean-Christophe PLAGNIOL-VILLARD
2012-11-19 10:26 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-11-16 20:17 UTC (permalink / raw)
To: barebox
those led can have 2 colors but one at a time otherwise they are black
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
drivers/led/Kconfig | 4 ++++
drivers/led/led-gpio.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++
include/led.h | 20 ++++++++++++++++++++
3 files changed, 71 insertions(+)
diff --git a/drivers/led/Kconfig b/drivers/led/Kconfig
index 106093b..8ca6ab8 100644
--- a/drivers/led/Kconfig
+++ b/drivers/led/Kconfig
@@ -11,6 +11,10 @@ config LED_GPIO_RGB
bool "gpio rgb LED support"
depends on LED_GPIO
+config LED_GPIO_BICOLOR
+ bool "gpio bicolor LED support"
+ depends on LED_GPIO
+
config LED_TRIGGERS
select POLLER
bool "LED triggers support"
diff --git a/drivers/led/led-gpio.c b/drivers/led/led-gpio.c
index 711146b..c78ef9e 100644
--- a/drivers/led/led-gpio.c
+++ b/drivers/led/led-gpio.c
@@ -52,6 +52,53 @@ void led_gpio_unregister(struct gpio_led *led)
led_unregister(&led->led);
}
+#ifdef CONFIG_LED_GPIO_BICOLOR
+static void led_gpio_bicolor_set(struct led *led, unsigned int value)
+{
+ struct gpio_bicolor_led *bi = container_of(led, struct gpio_bicolor_led, led);
+ int al = bi->active_low;
+
+ switch (value) {
+ case 0:
+ gpio_direction_output(bi->gpio_c0, al);
+ gpio_direction_output(bi->gpio_c1, al);
+ break;
+ case 1:
+ gpio_direction_output(bi->gpio_c0, !al);
+ gpio_direction_output(bi->gpio_c1, al);
+ break;
+ case 2:
+ gpio_direction_output(bi->gpio_c0, al);
+ gpio_direction_output(bi->gpio_c1, !al);
+ break;
+ }
+}
+
+/**
+ * led_gpio_bicolor_register - register three gpios as a bicolor LED
+ * @param led The gpio bicolor LED
+ *
+ * This function registers three gpios as a bicolor LED. led->gpio[rg]
+ * should be initialized to the gpios to control.
+ */
+int led_gpio_bicolor_register(struct gpio_bicolor_led *led)
+{
+ led->led.set = led_gpio_bicolor_set;
+ led->led.max_value = 2;
+
+ return led_register(&led->led);
+}
+
+/**
+ * led_gpio_bicolor_unregister - remove a gpio controlled bicolor LED from the framework
+ * @param led The gpio LED
+ */
+void led_gpio_bicolor_unregister(struct gpio_bicolor_led *led)
+{
+ led_unregister(&led->led);
+}
+#endif
+
#ifdef CONFIG_LED_GPIO_RGB
static void led_gpio_rgb_set(struct led *led, unsigned int value)
diff --git a/include/led.h b/include/led.h
index 9ec1f0d..dd551fe 100644
--- a/include/led.h
+++ b/include/led.h
@@ -65,6 +65,12 @@ struct gpio_led {
struct led led;
};
+struct gpio_bicolor_led {
+ int gpio_c0, gpio_c1;
+ bool active_low;
+ struct led led;
+};
+
struct gpio_rgb_led {
int gpio_r, gpio_g, gpio_b;
bool active_low;
@@ -85,6 +91,20 @@ static inline void led_gpio_unregister(struct gpio_led *led)
}
#endif
+#ifdef CONFIG_LED_GPIO_BICOLOR
+int led_gpio_bicolor_register(struct gpio_bicolor_led *led);
+void led_gpio_bicolor_unregister(struct gpio_bicolor_led *led);
+#else
+static inline int led_gpio_bicolor_register(struct gpio_bicolor_led *led)
+{
+ return -ENOSYS;
+}
+
+static inline void led_gpio_bicolor_unregister(struct gpio_bicolor_led *led)
+{
+}
+#endif
+
#ifdef CONFIG_LED_GPIO_RGB
int led_gpio_rgb_register(struct gpio_rgb_led *led);
void led_gpio_rgb_unregister(struct gpio_led *led);
--
1.7.10.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] led-gpio: add bicolor led support
2012-11-16 20:17 [PATCH 1/1] led-gpio: add bicolor led support Jean-Christophe PLAGNIOL-VILLARD
@ 2012-11-19 10:26 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2012-11-19 10:26 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox
On Fri, Nov 16, 2012 at 09:17:23PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> those led can have 2 colors but one at a time otherwise they are black
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Applied, thanks
Sascha
> ---
> drivers/led/Kconfig | 4 ++++
> drivers/led/led-gpio.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++
> include/led.h | 20 ++++++++++++++++++++
> 3 files changed, 71 insertions(+)
>
> diff --git a/drivers/led/Kconfig b/drivers/led/Kconfig
> index 106093b..8ca6ab8 100644
> --- a/drivers/led/Kconfig
> +++ b/drivers/led/Kconfig
> @@ -11,6 +11,10 @@ config LED_GPIO_RGB
> bool "gpio rgb LED support"
> depends on LED_GPIO
>
> +config LED_GPIO_BICOLOR
> + bool "gpio bicolor LED support"
> + depends on LED_GPIO
> +
> config LED_TRIGGERS
> select POLLER
> bool "LED triggers support"
> diff --git a/drivers/led/led-gpio.c b/drivers/led/led-gpio.c
> index 711146b..c78ef9e 100644
> --- a/drivers/led/led-gpio.c
> +++ b/drivers/led/led-gpio.c
> @@ -52,6 +52,53 @@ void led_gpio_unregister(struct gpio_led *led)
> led_unregister(&led->led);
> }
>
> +#ifdef CONFIG_LED_GPIO_BICOLOR
> +static void led_gpio_bicolor_set(struct led *led, unsigned int value)
> +{
> + struct gpio_bicolor_led *bi = container_of(led, struct gpio_bicolor_led, led);
> + int al = bi->active_low;
> +
> + switch (value) {
> + case 0:
> + gpio_direction_output(bi->gpio_c0, al);
> + gpio_direction_output(bi->gpio_c1, al);
> + break;
> + case 1:
> + gpio_direction_output(bi->gpio_c0, !al);
> + gpio_direction_output(bi->gpio_c1, al);
> + break;
> + case 2:
> + gpio_direction_output(bi->gpio_c0, al);
> + gpio_direction_output(bi->gpio_c1, !al);
> + break;
> + }
> +}
> +
> +/**
> + * led_gpio_bicolor_register - register three gpios as a bicolor LED
> + * @param led The gpio bicolor LED
> + *
> + * This function registers three gpios as a bicolor LED. led->gpio[rg]
> + * should be initialized to the gpios to control.
> + */
> +int led_gpio_bicolor_register(struct gpio_bicolor_led *led)
> +{
> + led->led.set = led_gpio_bicolor_set;
> + led->led.max_value = 2;
> +
> + return led_register(&led->led);
> +}
> +
> +/**
> + * led_gpio_bicolor_unregister - remove a gpio controlled bicolor LED from the framework
> + * @param led The gpio LED
> + */
> +void led_gpio_bicolor_unregister(struct gpio_bicolor_led *led)
> +{
> + led_unregister(&led->led);
> +}
> +#endif
> +
> #ifdef CONFIG_LED_GPIO_RGB
>
> static void led_gpio_rgb_set(struct led *led, unsigned int value)
> diff --git a/include/led.h b/include/led.h
> index 9ec1f0d..dd551fe 100644
> --- a/include/led.h
> +++ b/include/led.h
> @@ -65,6 +65,12 @@ struct gpio_led {
> struct led led;
> };
>
> +struct gpio_bicolor_led {
> + int gpio_c0, gpio_c1;
> + bool active_low;
> + struct led led;
> +};
> +
> struct gpio_rgb_led {
> int gpio_r, gpio_g, gpio_b;
> bool active_low;
> @@ -85,6 +91,20 @@ static inline void led_gpio_unregister(struct gpio_led *led)
> }
> #endif
>
> +#ifdef CONFIG_LED_GPIO_BICOLOR
> +int led_gpio_bicolor_register(struct gpio_bicolor_led *led);
> +void led_gpio_bicolor_unregister(struct gpio_bicolor_led *led);
> +#else
> +static inline int led_gpio_bicolor_register(struct gpio_bicolor_led *led)
> +{
> + return -ENOSYS;
> +}
> +
> +static inline void led_gpio_bicolor_unregister(struct gpio_bicolor_led *led)
> +{
> +}
> +#endif
> +
> #ifdef CONFIG_LED_GPIO_RGB
> int led_gpio_rgb_register(struct gpio_rgb_led *led);
> void led_gpio_rgb_unregister(struct gpio_led *led);
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-19 10:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-16 20:17 [PATCH 1/1] led-gpio: add bicolor led support Jean-Christophe PLAGNIOL-VILLARD
2012-11-19 10:26 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox