* [PATCH] OMAP4: removed __packed__ annotation from pad_conf_entry
@ 2012-12-04 12:03 Enrico Scholz
2012-12-05 7:39 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Enrico Scholz @ 2012-12-04 12:03 UTC (permalink / raw)
To: barebox; +Cc: Enrico Scholz
structure is used within barebox only and there is no need to pack it.
As this option has a negative performance impact, remove it.
Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
---
arch/arm/mach-omap/include/mach/omap4-mux.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap/include/mach/omap4-mux.h b/arch/arm/mach-omap/include/mach/omap4-mux.h
index 9088631..db92a61 100644
--- a/arch/arm/mach-omap/include/mach/omap4-mux.h
+++ b/arch/arm/mach-omap/include/mach/omap4-mux.h
@@ -30,7 +30,7 @@ struct pad_conf_entry {
u16 val;
-} __attribute__ ((packed));
+};
#define WAKEUP_EN (1 << 14)
#ifdef CONFIG_OFF_PADCONF
--
1.7.11.7
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] OMAP4: removed __packed__ annotation from pad_conf_entry
2012-12-04 12:03 [PATCH] OMAP4: removed __packed__ annotation from pad_conf_entry Enrico Scholz
@ 2012-12-05 7:39 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2012-12-05 7:39 UTC (permalink / raw)
To: Enrico Scholz; +Cc: barebox
On Tue, Dec 04, 2012 at 01:03:31PM +0100, Enrico Scholz wrote:
> structure is used within barebox only and there is no need to pack it.
> As this option has a negative performance impact, remove it.
>
> Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Applied, thanks
Sascha
> ---
> arch/arm/mach-omap/include/mach/omap4-mux.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap/include/mach/omap4-mux.h b/arch/arm/mach-omap/include/mach/omap4-mux.h
> index 9088631..db92a61 100644
> --- a/arch/arm/mach-omap/include/mach/omap4-mux.h
> +++ b/arch/arm/mach-omap/include/mach/omap4-mux.h
> @@ -30,7 +30,7 @@ struct pad_conf_entry {
>
> u16 val;
>
> -} __attribute__ ((packed));
> +};
>
> #define WAKEUP_EN (1 << 14)
> #ifdef CONFIG_OFF_PADCONF
> --
> 1.7.11.7
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-05 7:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-04 12:03 [PATCH] OMAP4: removed __packed__ annotation from pad_conf_entry Enrico Scholz
2012-12-05 7:39 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox