[PATCH] mtd-core: fix compiler warning

[PATCH] mtd-core: fix compiler warning

[Alexander Aring]

Got this compile warning if MTD_WRITE support isn't set.

drivers/mtd/core.c: In function 'mtd_ioctl':
drivers/mtd/core.c:117:26: warning: unused variable 'ei' [-Wunused-variable]

Add a #ifdef to declaration of variable 'ei' to solve it.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
 drivers/mtd/core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mtd/core.c b/drivers/mtd/core.c
index af6e195..070fda6 100644
--- a/drivers/mtd/core.c
+++ b/drivers/mtd/core.c
@@ -114,7 +114,9 @@ int mtd_ioctl(struct cdev *cdev, int request, void *buf)
 	struct mtd_ecc_stats *ecc = buf;
 #endif
 	struct region_info_user *reg = buf;
+#ifdef CONFIG_MTD_WRITE
 	struct erase_info_user *ei = buf;
+#endif
 	loff_t *offset = buf;
 
 	switch (request) {
-- 
1.8.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] mtd-core: fix compiler warning

[Sascha Hauer]

On Wed, Jan 16, 2013 at 10:06:35PM +0100, Alexander Aring wrote:
> Got this compile warning if MTD_WRITE support isn't set.
> 
> drivers/mtd/core.c: In function 'mtd_ioctl':
> drivers/mtd/core.c:117:26: warning: unused variable 'ei' [-Wunused-variable]
> 
> Add a #ifdef to declaration of variable 'ei' to solve it.
> 
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>

Applied, thanks

Sascha

> ---
>  drivers/mtd/core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/core.c b/drivers/mtd/core.c
> index af6e195..070fda6 100644
> --- a/drivers/mtd/core.c
> +++ b/drivers/mtd/core.c
> @@ -114,7 +114,9 @@ int mtd_ioctl(struct cdev *cdev, int request, void *buf)
>  	struct mtd_ecc_stats *ecc = buf;
>  #endif
>  	struct region_info_user *reg = buf;
> +#ifdef CONFIG_MTD_WRITE
>  	struct erase_info_user *ei = buf;
> +#endif
>  	loff_t *offset = buf;
>  
>  	switch (request) {
> -- 
> 1.8.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox