From: Alexander Aring <alex.aring@gmail.com>
To: barebox@lists.infradead.org
Subject: [PATCH 0/4] Small fixes in barebox
Date: Thu, 7 Feb 2013 21:36:16 +0100 [thread overview]
Message-ID: <1360269380-28155-1-git-send-email-alex.aring@gmail.com> (raw)
First I tried to change getopt optstring argument to "const char *"
and I test it with an allyesconfig for compiler warnings.
Then there popup some compile errors, which I tried to fix.
I am not happy with some of these solutions. Maybe someone have an idea
how we can make it better.
hush: add getopt only if it enabled
- I don't know if this needs a fix. But if we disable getopt there is a
no-op getopt implementation in the command list. This patch don't add
getopt to the command list at runtime, but the no-op implementation is
still there. Maybe a compiletime solution is better to remove the
no-op implementation.
sata-imx: fix depends on ARCH_IMX
- I am not sure but this looks like ARCH_IMX related things. I got a error
that some imx51 header files could'nt be found.
net: fix cpsw depends on ARCH_OMAP
- Same thing like sata-imx. I got a compile error that mach/cpsw.h wasn't
found. I only found that in the omap implementation.
Another (maybe toolchain related issue) is:
barebox/lib/libubigen.c:105: undefined reference to `__divdi3'
Is it in this line:
tmp = (vi->bytes + ui->leb_size - 1) / ui->leb_size;
If we know that ui->leb_size is a power-of-two, we can use a shift for this
instead of division. But I don't know if leb_size a power-of-two number.
Alexander Aring (4):
hush: add getopt only if it enabled
getopt: change optstring to const char*
sata-imx: fix depends on ARCH_IMX
net: fix cpsw depends on ARCH_OMAP
common/hush.c | 3 ++-
drivers/ata/Kconfig | 1 +
drivers/net/Kconfig | 1 +
include/getopt.h | 2 +-
lib/getopt.c | 4 ++--
5 files changed, 7 insertions(+), 4 deletions(-)
--
1.8.1.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2013-02-07 20:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 20:36 Alexander Aring [this message]
2013-02-07 20:36 ` [PATCH 1/4] hush: add getopt only if it enabled Alexander Aring
2013-02-07 20:36 ` [PATCH 2/4] getopt: change optstring to const char* Alexander Aring
2013-02-07 20:36 ` [PATCH 3/4] sata-imx: fix depends on ARCH_IMX Alexander Aring
2013-02-07 20:36 ` [PATCH 4/4] net: fix cpsw depends on ARCH_OMAP Alexander Aring
2013-02-07 21:27 ` Alexander Aring
2013-02-07 21:35 ` [PATCH 0/4] Small fixes in barebox Sascha Hauer
2013-02-07 21:41 ` Sascha Hauer
2013-02-07 21:50 ` Alexander Aring
2013-02-08 8:29 ` Sascha Hauer
2013-02-07 21:47 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360269380-28155-1-git-send-email-alex.aring@gmail.com \
--to=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox