* [PATCH 1/1] phy/micrel: KSZ9021 diasable Asym Pause support
@ 2013-02-08 8:55 Jean-Christophe PLAGNIOL-VILLARD
2013-02-11 9:58 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2013-02-08 8:55 UTC (permalink / raw)
To: barebox
Due to a hw bug do not enable teh Asym_Pause.
Otherwise if you ser the bit 11 in 4h you will have to unplug
and replug the cable to make the phy work.
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
drivers/net/phy/micrel.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index ed5abf8..c0bcdd1 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -148,11 +148,15 @@ static struct phy_driver ksphy_driver[] = {
.config_aneg = genphy_config_aneg,
.read_status = genphy_read_status,
}, {
+ /*
+ * Due to a hw bug do not enable the Asym_Pause.
+ * Otherwise if you set the bit 11 in 4h you will have to unplug
+ * and replug the cable to make the phy work.
+ */
.phy_id = PHY_ID_KSZ9021,
.phy_id_mask = 0x000ffffe,
.drv.name = "Micrel KSZ9021 Gigabit PHY",
- .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause
- | SUPPORTED_Asym_Pause),
+ .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause),
.config_init = kszphy_config_init,
.config_aneg = genphy_config_aneg,
.read_status = genphy_read_status,
--
1.7.10.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] phy/micrel: KSZ9021 diasable Asym Pause support
2013-02-08 8:55 [PATCH 1/1] phy/micrel: KSZ9021 diasable Asym Pause support Jean-Christophe PLAGNIOL-VILLARD
@ 2013-02-11 9:58 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2013-02-11 9:58 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox
On Fri, Feb 08, 2013 at 09:55:50AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Due to a hw bug do not enable teh Asym_Pause.
> Otherwise if you ser the bit 11 in 4h you will have to unplug
> and replug the cable to make the phy work.
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Applied, thanks
Sascha
> ---
> drivers/net/phy/micrel.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index ed5abf8..c0bcdd1 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -148,11 +148,15 @@ static struct phy_driver ksphy_driver[] = {
> .config_aneg = genphy_config_aneg,
> .read_status = genphy_read_status,
> }, {
> + /*
> + * Due to a hw bug do not enable the Asym_Pause.
> + * Otherwise if you set the bit 11 in 4h you will have to unplug
> + * and replug the cable to make the phy work.
> + */
> .phy_id = PHY_ID_KSZ9021,
> .phy_id_mask = 0x000ffffe,
> .drv.name = "Micrel KSZ9021 Gigabit PHY",
> - .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause
> - | SUPPORTED_Asym_Pause),
> + .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause),
> .config_init = kszphy_config_init,
> .config_aneg = genphy_config_aneg,
> .read_status = genphy_read_status,
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-11 9:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-08 8:55 [PATCH 1/1] phy/micrel: KSZ9021 diasable Asym Pause support Jean-Christophe PLAGNIOL-VILLARD
2013-02-11 9:58 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox