From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from f254.mail.ru ([217.69.128.179]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U7hKS-0002CJ-4m for barebox@lists.infradead.org; Tue, 19 Feb 2013 07:09:29 +0000 From: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= Mime-Version: 1.0 Date: Tue, 19 Feb 2013 11:09:23 +0400 Message-ID: <1361257763.676618458@f254.mail.ru> In-Reply-To: <20130218101919.GQ1906@pengutronix.de> References: <1360954167-18993-1-git-send-email-shc_work@mail.ru> <1361182402.423724727@f309.mail.ru> <20130218101919.GQ1906@pengutronix.de> Reply-To: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: =?UTF-8?B?UmVbMl06IFtSRkNdIEFkZCBHZW5lcmljIEdQSU8gZHJpdmVy?= To: =?UTF-8?B?U2FzY2hhIEhhdWVy?= Cc: barebox@lists.infradead.org > On Mon, Feb 18, 2013 at 02:13:22PM +0400, Alexander Shiyan wrote: > > > On Fri, Feb 15, 2013 at 10:49:27PM +0400, Alexander Shiyan wrote: > > > > This patch adds generic memory-mapped GPIO controller support. > > > > Code taken from Linux Kernel and adopted for barebox. > > > > > > I'm fine with this if you add a user for it. I wonder though if it's > > > worth it to have this driver for barebox. If I have a driver in the > > > kernel that already uses it, then this makes it simple to copy it, but > > > should I have to write a new gpio driver, I'm unsure if it's simpler > > > to write a new gpio driver or to register with the generic gpio > > > driver. > > > > Here's an example that I'm checking: > > Ok, this indeed looks nice and short. You convinced me ;) > > As said, I'm fine with the generic gpio driver if you add the below as > first user. I still beg to consider patch for generic GPIO separately. Then I will send you two completely different versions of the implementation GPIO for CLPS711X for consideration. ... > > /* > > * Copyright (C) 2013 Alexander Shiyan > > * > > * This program is free software; you can redistribute it and/or > > * modify it under the terms of the GNU General Public License as > > * published by the Free Software Foundation; either version 2 of > > * the License, or (at your option) any later version. > > */ > > > > #include > > #include > > #include > > > > #include ... --- _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox