mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 1/2] ARM i.MX: Fix booting from NOR when external nand boot is enabled
Date: Tue, 26 Feb 2013 11:00:41 +0100	[thread overview]
Message-ID: <1361872842-2336-1-git-send-email-s.hauer@pengutronix.de> (raw)

We cannot jump to SDRAM unconditionally in imx*_barebox_boot_nand_external.
When we really boot from NOR flash the binary is not yet copied to SDRAM.
Instead, let the return value of imx_barebox_boot_nand_external() indicate
whether we really boot from NAND and only jump to SDRAM in this case.
Otherwise just continue to the normal SoC specific entry.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/arm/mach-imx/external-nand-boot.c |   46 ++++++++++++++++++++------------
 1 file changed, 29 insertions(+), 17 deletions(-)

diff --git a/arch/arm/mach-imx/external-nand-boot.c b/arch/arm/mach-imx/external-nand-boot.c
index 2c353d7..73c4ccd 100644
--- a/arch/arm/mach-imx/external-nand-boot.c
+++ b/arch/arm/mach-imx/external-nand-boot.c
@@ -280,7 +280,7 @@ static __bare_init __naked void jump_sdram(unsigned long offset)
  * running inside the NFC address space. If not, barebox is started from the
  * currently running address without loading anything from NAND.
  */
-void __bare_init imx_barebox_boot_nand_external(unsigned long nfc_base)
+int __bare_init imx_barebox_boot_nand_external(unsigned long nfc_base)
 {
 	u32 r;
 	u32 *src, *trg;
@@ -289,7 +289,7 @@ void __bare_init imx_barebox_boot_nand_external(unsigned long nfc_base)
 	/* skip NAND boot if not running from NFC space */
 	r = get_pc();
 	if (r < nfc_base || r > nfc_base + 0x800)
-		return;
+		return 0;
 
 	src = (unsigned int *)nfc_base;
 	trg = (unsigned int *)_text;
@@ -297,6 +297,8 @@ void __bare_init imx_barebox_boot_nand_external(unsigned long nfc_base)
 	/* Move ourselves out of NFC SRAM */
 	for (i = 0; i < 0x800 / sizeof(int); i++)
 		*trg++ = *src++;
+
+	return 1;
 }
 
 /*
@@ -310,9 +312,11 @@ void __bare_init __noreturn imx21_barebox_boot_nand_external(void)
 {
 	unsigned long nfc_base = MX21_NFC_BASE_ADDR;
 
-	imx_barebox_boot_nand_external(nfc_base);
-	jump_sdram(nfc_base - (unsigned long)_text);
-	imx_nand_load_image((void *)_text, barebox_image_size);
+	if (imx_barebox_boot_nand_external(nfc_base)) {
+		jump_sdram(nfc_base - (unsigned long)_text);
+		imx_nand_load_image((void *)_text, barebox_image_size);
+	}
+
 	imx21_barebox_entry(0);
 }
 #endif
@@ -322,9 +326,11 @@ void __bare_init __noreturn imx25_barebox_boot_nand_external(void)
 {
 	unsigned long nfc_base = MX25_NFC_BASE_ADDR;
 
-	imx_barebox_boot_nand_external(nfc_base);
-	jump_sdram(nfc_base - (unsigned long)_text);
-	imx_nand_load_image((void *)_text, barebox_image_size);
+	if (imx_barebox_boot_nand_external(nfc_base)) {
+		jump_sdram(nfc_base - (unsigned long)_text);
+		imx_nand_load_image((void *)_text, barebox_image_size);
+	}
+
 	imx25_barebox_entry(0);
 }
 #endif
@@ -334,9 +340,11 @@ void __bare_init __noreturn imx27_barebox_boot_nand_external(void)
 {
 	unsigned long nfc_base = MX27_NFC_BASE_ADDR;
 
-	imx_barebox_boot_nand_external(nfc_base);
-	jump_sdram(nfc_base - (unsigned long)_text);
-	imx_nand_load_image((void *)_text, barebox_image_size);
+	if (imx_barebox_boot_nand_external(nfc_base)) {
+		jump_sdram(nfc_base - (unsigned long)_text);
+		imx_nand_load_image((void *)_text, barebox_image_size);
+	}
+
 	imx27_barebox_entry(0);
 }
 #endif
@@ -346,9 +354,11 @@ void __bare_init __noreturn imx31_barebox_boot_nand_external(void)
 {
 	unsigned long nfc_base = MX31_NFC_BASE_ADDR;
 
-	imx_barebox_boot_nand_external(nfc_base);
-	jump_sdram(nfc_base - (unsigned long)_text);
-	imx_nand_load_image((void *)_text, barebox_image_size);
+	if (imx_barebox_boot_nand_external(nfc_base)) {
+		jump_sdram(nfc_base - (unsigned long)_text);
+		imx_nand_load_image((void *)_text, barebox_image_size);
+	}
+
 	imx31_barebox_entry(0);
 }
 #endif
@@ -358,9 +368,11 @@ void __bare_init __noreturn imx35_barebox_boot_nand_external(void)
 {
 	unsigned long nfc_base = MX35_NFC_BASE_ADDR;
 
-	imx_barebox_boot_nand_external(nfc_base);
-	jump_sdram(nfc_base - (unsigned long)_text);
-	imx_nand_load_image((void *)_text, barebox_image_size);
+	if (imx_barebox_boot_nand_external(nfc_base)) {
+		jump_sdram(nfc_base - (unsigned long)_text);
+		imx_nand_load_image((void *)_text, barebox_image_size);
+	}
+
 	imx35_barebox_entry(0);
 }
 #endif
-- 
1.7.10.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2013-02-26 10:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-26 10:00 Sascha Hauer [this message]
2013-02-26 10:00 ` [PATCH 2/2] ARM i.MX35: Let MAX clk be in run-mode-on Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361872842-2336-1-git-send-email-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox