* [RFC] Makefile: Create empty <config.h> if this header file is not needed by board
@ 2013-03-06 18:30 Alexander Shiyan
2013-03-10 11:08 ` Alexander Shiyan
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Shiyan @ 2013-03-06 18:30 UTC (permalink / raw)
To: barebox
Patch creates empty <config.h> if this header is not needed by board.
This will allow to remove many empty config.h files from boards.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
Makefile | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/Makefile b/Makefile
index b5819fc..e8d9984 100644
--- a/Makefile
+++ b/Makefile
@@ -898,13 +898,18 @@ include/asm:
$(Q)$(check-symlink)
$(Q)$(create-symlink)
+define symlink-config-h
+ if [ -f $(srctree)/$(BOARD)/config.h ]; then \
+ $(kecho) ' SYMLINK $@ -> $(BOARD)/config.h'; \
+ ln -fsn $(srctree)/$(BOARD)/config.h $@; \
+ else \
+ $(kecho) ' CREATE $@'; \
+ echo -n > $@; \
+ fi
+endef
+
include/config.h: include/config/auto.conf
- $(Q)$(kecho) ' SYMLINK $@ -> $(BOARD)/config.h'
-ifneq ($(KBUILD_SRC),)
- $(Q)ln -fsn $(srctree)/$(BOARD)/config.h $@
-else
- $(Q)ln -fsn ../$(BOARD)/config.h $@
-endif
+ $(Q)$(symlink-config-h)
# Generate some files
# ---------------------------------------------------------------------------
--
1.7.12.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] Makefile: Create empty <config.h> if this header file is not needed by board
2013-03-06 18:30 [RFC] Makefile: Create empty <config.h> if this header file is not needed by board Alexander Shiyan
@ 2013-03-10 11:08 ` Alexander Shiyan
2013-03-10 14:56 ` Sascha Hauer
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Shiyan @ 2013-03-10 11:08 UTC (permalink / raw)
To: barebox, Sascha Hauer
> Patch creates empty <config.h> if this header is not needed by board.
> This will allow to remove many empty config.h files from boards.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> Makefile | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index b5819fc..e8d9984 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -898,13 +898,18 @@ include/asm:
> $(Q)$(check-symlink)
> $(Q)$(create-symlink)
>
> +define symlink-config-h
> + if [ -f $(srctree)/$(BOARD)/config.h ]; then \
> + $(kecho) ' SYMLINK $@ -> $(BOARD)/config.h'; \
> + ln -fsn $(srctree)/$(BOARD)/config.h $@; \
> + else \
> + $(kecho) ' CREATE $@'; \
> + echo -n > $@; \
> + fi
> +endef
> +
> include/config.h: include/config/auto.conf
> - $(Q)$(kecho) ' SYMLINK $@ -> $(BOARD)/config.h'
> -ifneq ($(KBUILD_SRC),)
> - $(Q)ln -fsn $(srctree)/$(BOARD)/config.h $@
> -else
> - $(Q)ln -fsn ../$(BOARD)/config.h $@
> -endif
> + $(Q)$(symlink-config-h)
>
> # Generate some files
> # ---------------------------------------------------------------------------
> --
> 1.7.12.4
Can anyone comment this patch?
I can resend it with cleanup part. (-50 files).
---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] Makefile: Create empty <config.h> if this header file is not needed by board
2013-03-10 11:08 ` Alexander Shiyan
@ 2013-03-10 14:56 ` Sascha Hauer
2013-03-10 15:01 ` Re[2]: " Alexander Shiyan
0 siblings, 1 reply; 6+ messages in thread
From: Sascha Hauer @ 2013-03-10 14:56 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: barebox
On Sun, Mar 10, 2013 at 03:08:00PM +0400, Alexander Shiyan wrote:
> > Patch creates empty <config.h> if this header is not needed by board.
> > This will allow to remove many empty config.h files from boards.
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> > Makefile | 17 +++++++++++------
> > 1 file changed, 11 insertions(+), 6 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index b5819fc..e8d9984 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -898,13 +898,18 @@ include/asm:
> > $(Q)$(check-symlink)
> > $(Q)$(create-symlink)
> >
> > +define symlink-config-h
> > + if [ -f $(srctree)/$(BOARD)/config.h ]; then \
> > + $(kecho) ' SYMLINK $@ -> $(BOARD)/config.h'; \
> > + ln -fsn $(srctree)/$(BOARD)/config.h $@; \
> > + else \
> > + $(kecho) ' CREATE $@'; \
> > + echo -n > $@; \
> > + fi
How does git incorporate with this? I think git just ignores empty files
like these, right?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re[2]: [RFC] Makefile: Create empty <config.h> if this header file is not needed by board
2013-03-10 14:56 ` Sascha Hauer
@ 2013-03-10 15:01 ` Alexander Shiyan
2013-03-10 23:24 ` Sascha Hauer
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Shiyan @ 2013-03-10 15:01 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
> > > Patch creates empty <config.h> if this header is not needed by board.
> > > This will allow to remove many empty config.h files from boards.
> > >
> > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > > ---
> > > Makefile | 17 +++++++++++------
> > > 1 file changed, 11 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/Makefile b/Makefile
> > > index b5819fc..e8d9984 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -898,13 +898,18 @@ include/asm:
> > > $(Q)$(check-symlink)
> > > $(Q)$(create-symlink)
> > >
> > > +define symlink-config-h
> > > + if [ -f $(srctree)/$(BOARD)/config.h ]; then \
> > > + $(kecho) ' SYMLINK $@ -> $(BOARD)/config.h'; \
> > > + ln -fsn $(srctree)/$(BOARD)/config.h $@; \
> > > + else \
> > > + $(kecho) ' CREATE $@'; \
> > > + echo -n > $@; \
> > > + fi
>
> How does git incorporate with this? I think git just ignores empty files
> like these, right?
When I say "empty" here, I mean about not zeroed files, but about
files without any content. Now we have 50 config.h files like this.
---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] Makefile: Create empty <config.h> if this header file is not needed by board
2013-03-10 15:01 ` Re[2]: " Alexander Shiyan
@ 2013-03-10 23:24 ` Sascha Hauer
2013-03-11 16:10 ` Re[2]: " Alexander Shiyan
0 siblings, 1 reply; 6+ messages in thread
From: Sascha Hauer @ 2013-03-10 23:24 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: barebox
On Sun, Mar 10, 2013 at 07:01:00PM +0400, Alexander Shiyan wrote:
> > > > Patch creates empty <config.h> if this header is not needed by board.
> > > > This will allow to remove many empty config.h files from boards.
> >
> > How does git incorporate with this? I think git just ignores empty files
> > like these, right?
>
> When I say "empty" here, I mean about not zeroed files, but about
> files without any content. Now we have 50 config.h files like this.
My question aimed in the direction whether we end up with empty files
in git because people accidently add these now generated files.
I think the goal should be to get rid of the config.h files entirely.
This patch (or better: the removal of the empty files) could be a good
start to see what's left.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re[2]: [RFC] Makefile: Create empty <config.h> if this header file is not needed by board
2013-03-10 23:24 ` Sascha Hauer
@ 2013-03-11 16:10 ` Alexander Shiyan
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Shiyan @ 2013-03-11 16:10 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
> On Sun, Mar 10, 2013 at 07:01:00PM +0400, Alexander Shiyan wrote:
> > > > > Patch creates empty <config.h> if this header is not needed by board.
> > > > > This will allow to remove many empty config.h files from boards.
> > >
> > > How does git incorporate with this? I think git just ignores empty files
> > > like these, right?
> >
> > When I say "empty" here, I mean about not zeroed files, but about
> > files without any content. Now we have 50 config.h files like this.
>
> My question aimed in the direction whether we end up with empty files
> in git because people accidently add these now generated files.
>
> I think the goal should be to get rid of the config.h files entirely.
> This patch (or better: the removal of the empty files) could be a good
> start to see what's left.
OK, let's see. I will send the patch again. Second part is a cleanup.
---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-03-11 16:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-06 18:30 [RFC] Makefile: Create empty <config.h> if this header file is not needed by board Alexander Shiyan
2013-03-10 11:08 ` Alexander Shiyan
2013-03-10 14:56 ` Sascha Hauer
2013-03-10 15:01 ` Re[2]: " Alexander Shiyan
2013-03-10 23:24 ` Sascha Hauer
2013-03-11 16:10 ` Re[2]: " Alexander Shiyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox