From: "Alexander Shiyan" <shc_work@mail.ru>
To: barebox@lists.infradead.org, "Sascha Hauer" <s.hauer@pengutronix.de>
Subject: Re: [RFC] Makefile: Create empty <config.h> if this header file is not needed by board
Date: Sun, 10 Mar 2013 15:08:00 +0400 [thread overview]
Message-ID: <1362913680.690644667@f363.mail.ru> (raw)
In-Reply-To: <1362594605-1083-1-git-send-email-shc_work@mail.ru>
> Patch creates empty <config.h> if this header is not needed by board.
> This will allow to remove many empty config.h files from boards.
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> Makefile | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index b5819fc..e8d9984 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -898,13 +898,18 @@ include/asm:
> $(Q)$(check-symlink)
> $(Q)$(create-symlink)
>
> +define symlink-config-h
> + if [ -f $(srctree)/$(BOARD)/config.h ]; then \
> + $(kecho) ' SYMLINK $@ -> $(BOARD)/config.h'; \
> + ln -fsn $(srctree)/$(BOARD)/config.h $@; \
> + else \
> + $(kecho) ' CREATE $@'; \
> + echo -n > $@; \
> + fi
> +endef
> +
> include/config.h: include/config/auto.conf
> - $(Q)$(kecho) ' SYMLINK $@ -> $(BOARD)/config.h'
> -ifneq ($(KBUILD_SRC),)
> - $(Q)ln -fsn $(srctree)/$(BOARD)/config.h $@
> -else
> - $(Q)ln -fsn ../$(BOARD)/config.h $@
> -endif
> + $(Q)$(symlink-config-h)
>
> # Generate some files
> # ---------------------------------------------------------------------------
> --
> 1.7.12.4
Can anyone comment this patch?
I can resend it with cleanup part. (-50 files).
---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-03-10 11:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 18:30 Alexander Shiyan
2013-03-10 11:08 ` Alexander Shiyan [this message]
2013-03-10 14:56 ` Sascha Hauer
2013-03-10 15:01 ` Re[2]: " Alexander Shiyan
2013-03-10 23:24 ` Sascha Hauer
2013-03-11 16:10 ` Re[2]: " Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362913680.690644667@f363.mail.ru \
--to=shc_work@mail.ru \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox