From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp38.i.mail.ru ([94.100.177.98]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UOoZb-00008E-QH for barebox@lists.infradead.org; Sun, 07 Apr 2013 12:19:53 +0000 From: Alexander Shiyan Date: Sun, 7 Apr 2013 16:19:39 +0400 Message-Id: <1365337179-778-1-git-send-email-shc_work@mail.ru> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH] mci: Fix bug if probe parameter is omitted To: barebox@lists.infradead.org barebox@Phytec phyCORE-i.MX27:/ mci0.probe= unable to handle NULL pointer dereference at address 0x00000000 pc : [] lr : [] sp : a7fff8e0 ip : 00000000 fp : 00000001 r10: 00000000 r9 : a6ffba8c r8 : 00000000 r7 : a7fffad0 r6 : a6ffbb04 r5 : a6fdd5cc r4 : a6fdd658 r3 : a7f18760 r2 : 00000000 r1 : 00000000 r0 : 00000000 Flags: nZCv IRQs off FIQs off Mode SVC_32 [] (simple_strtoul+0xc/0xc0) from [] (mci_set_probe+0xc94/0xd64) [] (mci_set_probe+0xc94/0xd64) from [] (dev_set_param+0x74/0x8c) [] (dev_set_param+0x74/0x8c) from [] (setenv+0x60/0xd8) [] (setenv+0x60/0xd8) from [] (set_local_var.isra.3+0x5c/0x7c) [] (set_local_var.isra.3+0x5c/0x7c) from [] (run_list_real+0x494/0x934) [] (run_list_real+0x494/0x934) from [] (parse_stream_outer+0x198/0x270) [] (parse_stream_outer+0x198/0x270) from [] (run_shell+0x3c/0x7c) [] (run_shell+0x3c/0x7c) from [] (execute_command+0x38/0x78) [] (execute_command+0x38/0x78) from [] (run_list_real+0x7e0/0x934) [] (run_list_real+0x7e0/0x934) from [] (run_list_real+0x414/0x934) [] (unwind_backtrace+0x0/0xa8) from [] (panic+0x28/0x3c) [] (panic+0x28/0x3c) from [] (do_exception+0x10/0x14) [] (do_exception+0x10/0x14) from [] (do_data_abort+0x2c/0x38) [] (do_data_abort+0x2c/0x38) from [] (data_abort+0x48/0x60) Signed-off-by: Alexander Shiyan --- drivers/mci/mci-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c index c8598c2..aef5c69 100644 --- a/drivers/mci/mci-core.c +++ b/drivers/mci/mci-core.c @@ -1465,6 +1465,9 @@ static int mci_set_probe(struct device_d *mci_dev, struct param_d *param, if (rc != 0) return 0; + if (!val) + return -EINVAL; + probe = simple_strtoul(val, NULL, 0); if (probe != 0) { rc = mci_card_probe(mci); -- 1.8.1.5 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox