From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from f78.mail.ru ([217.69.128.226]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UUCyC-00026Z-00 for barebox@lists.infradead.org; Mon, 22 Apr 2013 09:23:33 +0000 From: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= Mime-Version: 1.0 Date: Mon, 22 Apr 2013 13:23:24 +0400 Message-ID: <1366622604.908846815@f78.mail.ru> In-Reply-To: <20130422072152.GH32299@pengutronix.de> References: <1366431532-29121-1-git-send-email-shc_work@mail.ru> <1366613952.633427022@f229.mail.ru> <20130422072152.GH32299@pengutronix.de> Reply-To: =?UTF-8?B?QWxleGFuZGVyIFNoaXlhbg==?= List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: =?UTF-8?B?UmVbMl06IFtQQVRDSCAzLzVdIEdQSU86IGkuTVg6IFJld3JpdGUgZHJpdmVy?= =?UTF-8?B?IGZvciB1c2luZyBnZW5lcmljIEdQSU8gY29kZQ==?= To: =?UTF-8?B?U2FzY2hhIEhhdWVy?= Cc: barebox@lists.infradead.org > > > On Sat, Apr 20, 2013 at 08:18:50AM +0400, Alexander Shiyan wrote: > > > > > > > > Signed-off-by: Alexander Shiyan > > > > --- > > > > arch/arm/Kconfig | 1 - > > > > drivers/gpio/Kconfig | 1 + > > > > drivers/gpio/gpio-imx.c | 125 ++++++++++++------------------------------------ > > > > 3 files changed, 31 insertions(+), 96 deletions(-) ... > > > > config GPIO_IMX > > > > def_bool ARCH_IMX > > > > + select GPIO_GENERIC > > > > > > I'm not convinced by this change. Indeed this makes for smaller > > > sourcecode, but the binary gets over 1kb bigger. I think this is too > > > much for no additional gain. > > > > The main idea of this change is reuse code if we can have multiple > > targets in barebox. Probably, now is too early for this. > > Yeah, it may change once multiple gpio drivers are compiled into the > binary. > > BTW maybe you can lower the impact of the generic gpio driver by making > the basic-mmio-gpio platform driver optional. It is not used by the i.MX > part. "basic-mmio-gpio" driver is a part of generic GPIO but it is already a separate config symbol GPIO_GENERIC_PLATFORM. In any case I will think about optimization this code. --- _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox