mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Jean-Christophe PLAGNIOL-VILLARD" <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re[2]: [PATCH] clocksource: Add pointer to clocksource structure in read function
Date: Mon, 22 Apr 2013 18:19:19 +0400	[thread overview]
Message-ID: <1366640359.9607106@f239.mail.ru> (raw)
In-Reply-To: <20130422135908.GB13393@game.jcrosoft.org>

> On 13:13 Mon 22 Apr     , Alexander Shiyan wrote:
> > > On 10:35 Sat 20 Apr     , Alexander Shiyan wrote:
> > > > 
> > > > This patch adds pointer to clocksource structure in read function.
> > > > For avoid name collisions, clocksource names for all drivers was
> > > > changed to be unique.
> > > why?
> > > 
> > > no need the clocksource is hot path don't touch it
> > > and we do not need the struct pointer as we can have only 1 cs in barebox
> > 
> > This change allows to add an additional field in struct clocksource then
> > we can remove static variables from clocksource drivers.
> why we have only one clocksource at a time
> what you propose will require to use container_of
> 
> so will slow down a lot barebox

I hope to see any comments about this patch from Sascha.
Of course, we have only one instance of clocksource, but generally
direction of this patch is avoid of usage static variables in clocksource drivers.
With path we can remove all usage. Is this not good for you?

---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-04-22 14:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-20  6:35 Alexander Shiyan
2013-04-20 16:59 ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-22  9:13   ` Re[2]: " Alexander Shiyan
2013-04-22 13:59     ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-22 14:19       ` Alexander Shiyan [this message]
2013-04-22 16:15         ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-22 16:22           ` Re[2]: " Alexander Shiyan
2013-04-22 17:03 ` Sascha Hauer
2013-04-22 17:12   ` Re[2]: " Alexander Shiyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366640359.9607106@f239.mail.ru \
    --to=shc_work@mail.ru \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox