Re: [PATCH] ARM: OMAP5 processors support

["Jan Lübbe" <jlu@pengutronix.de>]

On Thu, 2013-04-25 at 15:42 +0300, Uladzimir Bely wrote:
> 25.04.2013 14:58, Jan Lübbe пишет:
> > On Thu, 2013-04-25 at 12:09 +0300, Uladzimir Bely wrote:
> >> diff --git a/arch/arm/boards/omap5_sevm/env/config b/arch/arm/boards/omap5_sevm/env/config
> >> new file mode 100644
> >> index 0000000..9752957
> >> --- /dev/null
> >> +++ b/arch/arm/boards/omap5_sevm/env/config
> >> @@ -0,0 +1,11 @@
> >> +#!/bin/sh
> >> +
> >> +machine=omap5
> >> +
> >> +autoboot_timeout=2
> >> +
> >> +bootargs="console=ttyO2,115200"
> >> +
> >> +kernel_loc=disk
> >> +
> >> +PS1="\e[1;32mbarebox@\e[1;31m\h:\w\e[0m "
> >
> > Please use defaultenv-2.
> >
> 
> I'm not too familiar with barebox's defaultenv/defaultenv-2. Our work on
> omap5 was based mostly on omap5 code from U-Boot and omap4 code from barebox.
> Mostly, I used pcm049 as an example of omap4-based board in barebox. So
> arch/arm/boards/omap5_sevm/env/config looks like this one, but includes
> only most necessary thinks to load to barebox prompt.
> 
> Please, give me a hint, which board can be used as an example of using
> defaultenv-2, maybe I'll do something.

Take a look at arch/arm/boards/beagle (omap3) or arch/arm/boards/panda
(omap4).

> >> diff --git a/arch/arm/mach-omap/Kconfig b/arch/arm/mach-omap/Kconfig
> >> index 42e5f4a..0ad3864 100644
> >> --- a/arch/arm/mach-omap/Kconfig
> >> +++ b/arch/arm/mach-omap/Kconfig
> >> @@ -41,6 +41,14 @@ config ARCH_OMAP4
> >>   	help
> >>   	  Say Y here if you are using Texas Instrument's OMAP4 based platform
> >>
> >> +config ARCH_OMAP5
> >> +	bool "OMAP5"
> >> +	select CPU_V7
> >> +	select GENERIC_GPIO
> >> +	select OMAP_CLOCK_SOURCE_S32K
> >> +	help
> >> +	  Say Y here if you are using Texas Instrument's OMAP5 based platform
> >> +
> >>   config ARCH_AM33XX
> >>   	bool "AM33xx"
> >>   	select CPU_V7
> >> @@ -115,6 +123,7 @@ config BOARDINFO
> >>   	default "Phytec phyCARD-A-L1" if MACH_PCAAL1
> >>   	default "Phytec phyCARD-A-XL2" if MACH_PCAAXL2
> >>   	default "Phytec phyCORE-AM335x" if MACH_PCM051
> >> +	default "Phytec phyCORE omap5_sevm" if MACH_OMAP5_SEVM
> >>
> >>   choice
> >>   	prompt "Select OMAP board"
> >> @@ -177,6 +186,13 @@ config MACH_PCAAXL2
> >>   	help
> >>   	  Say Y here if you are using a phyCARD-A-XL1 PCA-A-XL1
> >>
> >> +config MACH_OMAP5_SEVM
> >> +	bool "Phytec phyCORE omap5_sevm"
> >> +	depends on ARCH_OMAP5
> >> +	help
> >> +	  Say Y here if you are using Phytecs phyCORE omap5_sevm board
> >> +	  based on OMAP5
> >> +
> >>   config MACH_PCM051
> >>   	bool "Phytec phyCORE pcm051"
> >>   	select OMAP_CLOCK_ALL
> >
> > Isn't the OMAP5 sEVM from TI?
> >
> 
> We worked with OMAP5-based board, produced by Phytec (Phytec phyCORE-OMAP5),
> but, as I have mentioned above, code was partially ported from U-Boot's
> OMAP5-sevm board. I'll correct it.

The names should be consistent and match the hardware the new code you
are adding in this patch is intended for.

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox