mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Philipp Zabel <philipp.zabel@gmail.com>
To: barebox@lists.infradead.org
Subject: [PATCH 2/3] USB: chipidea-imx: add basic device tree support
Date: Mon, 27 May 2013 23:59:11 +0200	[thread overview]
Message-ID: <1369691952-3603-2-git-send-email-philipp.zabel@gmail.com> (raw)
In-Reply-To: <1369691952-3603-1-git-send-email-philipp.zabel@gmail.com>

This adds device tree support to the chipidea-imx driver.
There is no way to set flags or enable ULPI yet. Only host
mode is supported for now.

Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
---
 drivers/usb/imx/chipidea-imx.c |   33 ++++++++++++++++++++++++++-------
 1 file changed, 26 insertions(+), 7 deletions(-)

diff --git a/drivers/usb/imx/chipidea-imx.c b/drivers/usb/imx/chipidea-imx.c
index 1570f90..87e6a9d 100644
--- a/drivers/usb/imx/chipidea-imx.c
+++ b/drivers/usb/imx/chipidea-imx.c
@@ -29,11 +29,11 @@ static int imx_chipidea_port_init(void *drvdata)
 	struct imxusb_platformdata *pdata = dev->platform_data;
 	int ret;
 
-	ret = imx_usbmisc_port_init(dev->id, pdata->flags);
+	ret = imx_usbmisc_port_init(dev->id, pdata ? pdata->flags : 0);
 	if (ret)
 		dev_err(dev, "misc init failed: %s\n", strerror(-ret));
 
-	if (pdata->init)
+	if (pdata && pdata->init)
 		pdata->init(dev->id);
 
 	return ret;
@@ -45,7 +45,7 @@ static int imx_chipidea_port_post_init(void *drvdata)
 	struct imxusb_platformdata *pdata = dev->platform_data;
 	int ret;
 
-	ret = imx_usbmisc_port_post_init(dev->id, pdata->flags);
+	ret = imx_usbmisc_port_post_init(dev->id, pdata ? pdata->flags : 0);
 	if (ret)
 		dev_err(dev, "post misc init failed: %s\n", strerror(-ret));
 
@@ -60,7 +60,16 @@ static int imx_chipidea_probe(struct device_d *dev)
 	struct ehci_data data = {};
 	uint32_t portsc;
 
-	if (!pdata) {
+	if (IS_ENABLED(CONFIG_OFDEVICE) && dev->device_node) {
+		const void *args;
+
+		ret = of_parse_phandles_with_args(dev->device_node,
+				"fsl,usbmisc", "#index-cells", 0, NULL, &args);
+		if (ret < 0)
+			return -EINVAL;
+
+		dev->id = be32_to_cpu(*((__be32 *)args));
+	} else if (!pdata) {
 		dev_err(dev, "no pdata!\n");
 		return -EINVAL;
 	}
@@ -75,12 +84,13 @@ static int imx_chipidea_probe(struct device_d *dev)
 
 	portsc = readl(base + 0x184);
 	portsc &= ~MXC_EHCI_PORTSC_MASK;
-	portsc |= pdata->flags & MXC_EHCI_PORTSC_MASK;
+	if (pdata)
+		portsc |= pdata->flags & MXC_EHCI_PORTSC_MASK;
 	writel(portsc, base + 0x184);
 
 	imx_chipidea_port_init(dev);
 
-	if ((pdata->flags & MXC_EHCI_PORTSC_MASK) == MXC_EHCI_MODE_ULPI) {
+	if (pdata && ((pdata->flags & MXC_EHCI_PORTSC_MASK) == MXC_EHCI_MODE_ULPI)) {
 		dev_dbg(dev, "using ULPI phy\n");
 		if (IS_ENABLED(CONFIG_USB_ULPI)) {
 			ret = ulpi_setup(base + 0x170, 1);
@@ -97,7 +107,7 @@ static int imx_chipidea_probe(struct device_d *dev)
 	data.hcor = base + 0x140;
 	data.flags = EHCI_HAS_TT;
 
-	if (pdata->mode == IMX_USB_MODE_HOST && IS_ENABLED(CONFIG_USB_EHCI)) {
+	if (!pdata || (pdata->mode == IMX_USB_MODE_HOST && IS_ENABLED(CONFIG_USB_EHCI))) {
 		ret = ehci_register(dev, &data);
 	} else if (pdata->mode == IMX_USB_MODE_DEVICE && IS_ENABLED(CONFIG_USB_GADGET_DRIVER_ARC)) {
 		ret = ci_udc_register(dev, base);
@@ -109,8 +119,17 @@ static int imx_chipidea_probe(struct device_d *dev)
 	return ret;
 };
 
+static __maybe_unused struct of_device_id imx_chipidea_dt_ids[] = {
+	{
+		.compatible = "fsl,imx27-usb",
+	}, {
+		/* sentinel */
+	}
+};
+
 static struct driver_d imx_chipidea_driver = {
 	.name   = "imx-usb",
 	.probe  = imx_chipidea_probe,
+	.of_compatible = DRV_OF_COMPAT(imx_chipidea_dt_ids),
 };
 device_platform_driver(imx_chipidea_driver);
-- 
1.7.10.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-05-27 21:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-27 21:59 [PATCH 1/3] USB: imx-usb-misc: add " Philipp Zabel
2013-05-27 21:59 ` Philipp Zabel [this message]
2013-05-27 21:59 ` [PATCH 3/3] USB: imx-usb-phy: " Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369691952-3603-2-git-send-email-philipp.zabel@gmail.com \
    --to=philipp.zabel@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox