[PATCH] scripts: Makefile: do not use obj-* variables for userspace tools

[PATCH] scripts: Makefile: do not use obj-* variables for userspace tools

[Jan Luebbe]

When using obj-?, it erroneously tries to link a built-in.o. Instead
use the extra-? variable.

Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
---
 scripts/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/Makefile b/scripts/Makefile
index f062fc0..e375530 100644
--- a/scripts/Makefile
+++ b/scripts/Makefile
@@ -30,7 +30,7 @@ subdir-	+= basic kconfig setupmbr
 quiet_cmd_csingle	= CC      $@
       cmd_csingle	= $(CC) -Wp,-MD,$(depfile) $(CFLAGS) -o $@ $<
 
-obj-$(CONFIG_BAREBOXENV_TARGET)	+= bareboxenv-target
+extra-$(CONFIG_BAREBOXENV_TARGET) += bareboxenv-target
 
 scripts/bareboxenv-target: scripts/bareboxenv.c FORCE
 	$(call if_changed_dep,csingle)
-- 
1.8.2.rc2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] scripts: Makefile: do not use obj-* variables for userspace tools

[Sascha Hauer]

On Tue, May 28, 2013 at 11:39:44AM +0200, Jan Luebbe wrote:
> When using obj-?, it erroneously tries to link a built-in.o. Instead
> use the extra-? variable.
> 
> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>

Applied, thanks

Sascha

> ---
>  scripts/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/Makefile b/scripts/Makefile
> index f062fc0..e375530 100644
> --- a/scripts/Makefile
> +++ b/scripts/Makefile
> @@ -30,7 +30,7 @@ subdir-	+= basic kconfig setupmbr
>  quiet_cmd_csingle	= CC      $@
>        cmd_csingle	= $(CC) -Wp,-MD,$(depfile) $(CFLAGS) -o $@ $<
>  
> -obj-$(CONFIG_BAREBOXENV_TARGET)	+= bareboxenv-target
> +extra-$(CONFIG_BAREBOXENV_TARGET) += bareboxenv-target
>  
>  scripts/bareboxenv-target: scripts/bareboxenv.c FORCE
>  	$(call if_changed_dep,csingle)
> -- 
> 1.8.2.rc2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox