From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Masaki Muranaka" <monaka@monami-ya.jp>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Remove a redundant line.
Date: Sun, 02 Jun 2013 17:13:18 +0400 [thread overview]
Message-ID: <1370178798.173110869@f56.mail.ru> (raw)
In-Reply-To: <1370177945-36985-1-git-send-email-monaka@monami-ya.com>
> Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
> ---
> commands/echo.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/commands/echo.c b/commands/echo.c
> index 8929234..4dfd870 100644
> --- a/commands/echo.c
> +++ b/commands/echo.c
> @@ -55,7 +55,6 @@ static int do_echo(int argc, char *argv[])
> break;
> case 'o':
> oflags |= O_TRUNC;
> - file = argv[optind + 1];
> if (optind + 1 < argc)
> file = argv[optind + 1];
> else
> --
Nice catch. This is a possible crash.
---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-06-02 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-02 12:59 Masaki Muranaka
2013-06-02 13:13 ` Alexander Shiyan [this message]
2013-06-03 7:26 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370178798.173110869@f56.mail.ru \
--to=shc_work@mail.ru \
--cc=barebox@lists.infradead.org \
--cc=monaka@monami-ya.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox