mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Masaki Muranaka" <monaka@monami-ya.jp>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Remove ftstc(). It is declared but not implemented.
Date: Sun, 02 Jun 2013 19:47:24 +0400	[thread overview]
Message-ID: <1370188044.845875578@f297.mail.ru> (raw)
In-Reply-To: <1370178849-37125-1-git-send-email-monaka@monami-ya.com>

> ---
>  include/stdio.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/stdio.h b/include/stdio.h
> index 5c091a8..ff2572e 100644
> --- a/include/stdio.h
> +++ b/include/stdio.h
> @@ -101,7 +101,6 @@ static inline void putchar(char c)
>  int	fprintf(int file, const char *fmt, ...) __attribute__ ((format(__printf__, 2, 3)));
>  int	fputs(int file, const char *s);
>  int	fputc(int file, const char c);
> -int	ftstc(int file);
>  int	fgetc(int file);
>  
>  #endif /* __STDIO_H */
> -- 

Here (and in some other pathes) is missing Signed-off-by line.
Additionally, I want to focus on the fact that the address of From and Signed-off-by differ.
Git documentation says not to have been used aliases.
So, I think this field should be equal in the future.

---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-06-02 15:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-02 13:14 Masaki Muranaka
2013-06-02 15:47 ` Alexander Shiyan [this message]
2013-06-02 23:02   ` Masaki Muranaka
2013-06-02 23:02 Masaki Muranaka
2013-06-03  7:16 ` Sascha Hauer
2013-06-10  3:03 Masaki Muranaka
2013-06-11 15:29 ` Sascha Hauer
2013-06-12  5:50   ` Masaki Muranaka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370188044.845875578@f297.mail.ru \
    --to=shc_work@mail.ru \
    --cc=barebox@lists.infradead.org \
    --cc=monaka@monami-ya.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox