mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] Remove ftstc(). It is declared but not implemented.
@ 2013-06-02 13:14 Masaki Muranaka
  2013-06-02 15:47 ` Alexander Shiyan
  0 siblings, 1 reply; 8+ messages in thread
From: Masaki Muranaka @ 2013-06-02 13:14 UTC (permalink / raw)
  To: barebox

---
 include/stdio.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/stdio.h b/include/stdio.h
index 5c091a8..ff2572e 100644
--- a/include/stdio.h
+++ b/include/stdio.h
@@ -101,7 +101,6 @@ static inline void putchar(char c)
 int	fprintf(int file, const char *fmt, ...) __attribute__ ((format(__printf__, 2, 3)));
 int	fputs(int file, const char *s);
 int	fputc(int file, const char c);
-int	ftstc(int file);
 int	fgetc(int file);
 
 #endif /* __STDIO_H */
-- 
1.8.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] Remove ftstc(). It is declared but not implemented.
  2013-06-02 13:14 [PATCH] Remove ftstc(). It is declared but not implemented Masaki Muranaka
@ 2013-06-02 15:47 ` Alexander Shiyan
  2013-06-02 23:02   ` Masaki Muranaka
  0 siblings, 1 reply; 8+ messages in thread
From: Alexander Shiyan @ 2013-06-02 15:47 UTC (permalink / raw)
  To: Masaki Muranaka; +Cc: barebox

> ---
>  include/stdio.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/stdio.h b/include/stdio.h
> index 5c091a8..ff2572e 100644
> --- a/include/stdio.h
> +++ b/include/stdio.h
> @@ -101,7 +101,6 @@ static inline void putchar(char c)
>  int	fprintf(int file, const char *fmt, ...) __attribute__ ((format(__printf__, 2, 3)));
>  int	fputs(int file, const char *s);
>  int	fputc(int file, const char c);
> -int	ftstc(int file);
>  int	fgetc(int file);
>  
>  #endif /* __STDIO_H */
> -- 

Here (and in some other pathes) is missing Signed-off-by line.
Additionally, I want to focus on the fact that the address of From and Signed-off-by differ.
Git documentation says not to have been used aliases.
So, I think this field should be equal in the future.

---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] Remove ftstc(). It is declared but not implemented.
  2013-06-02 15:47 ` Alexander Shiyan
@ 2013-06-02 23:02   ` Masaki Muranaka
  0 siblings, 0 replies; 8+ messages in thread
From: Masaki Muranaka @ 2013-06-02 23:02 UTC (permalink / raw)
  To: Alexander Shiyan; +Cc: barebox

Hello,

It's easy to check by using whois service whether monami-ya.com and
monami-ya.jp are owned by same company...
Ok. I'll use monami-ya.jp in this project. I'm going to resend the patch.
Please inform me when I should fix my environment.

2013/6/3 Alexander Shiyan <shc_work@mail.ru>:
>> ---
>>  include/stdio.h | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/include/stdio.h b/include/stdio.h
>> index 5c091a8..ff2572e 100644
>> --- a/include/stdio.h
>> +++ b/include/stdio.h
>> @@ -101,7 +101,6 @@ static inline void putchar(char c)
>>  int  fprintf(int file, const char *fmt, ...) __attribute__ ((format(__printf__, 2, 3)));
>>  int  fputs(int file, const char *s);
>>  int  fputc(int file, const char c);
>> -int  ftstc(int file);
>>  int  fgetc(int file);
>>
>>  #endif /* __STDIO_H */
>> --
>
> Here (and in some other pathes) is missing Signed-off-by line.
> Additionally, I want to focus on the fact that the address of From and Signed-off-by differ.
> Git documentation says not to have been used aliases.
> So, I think this field should be equal in the future.
>
> ---



-- 
--
Masaki Muranaka
Monami-ya LLC, Japan.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] Remove ftstc(). It is declared but not implemented.
  2013-06-11 15:29 ` Sascha Hauer
@ 2013-06-12  5:50   ` Masaki Muranaka
  0 siblings, 0 replies; 8+ messages in thread
From: Masaki Muranaka @ 2013-06-12  5:50 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: barebox

Hello,

I couldn't find it on master branch at git://git.pengutronix.de/git/barebox.git.
You mean it was applied but not pushed yet?

2013/6/12 Sascha Hauer <s.hauer@pengutronix.de>:
> On Mon, Jun 10, 2013 at 12:03:29PM +0900, Masaki Muranaka wrote:
>> Signed-off-by: Masaki Muranaka <monaka@monami-ya.jp>
>
> I applied it already.
>
> Sascha
>
>> ---
>>  include/stdio.h | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/include/stdio.h b/include/stdio.h
>> index 5c091a8..ff2572e 100644
>> --- a/include/stdio.h
>> +++ b/include/stdio.h
>> @@ -101,7 +101,6 @@ static inline void putchar(char c)
>>  int  fprintf(int file, const char *fmt, ...) __attribute__ ((format(__printf__, 2, 3)));
>>  int  fputs(int file, const char *s);
>>  int  fputc(int file, const char c);
>> -int  ftstc(int file);
>>  int  fgetc(int file);
>>
>>  #endif /* __STDIO_H */
>> --
>> 1.8.3
>>
>>
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox
>>
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



-- 
--
Masaki Muranaka
Monami-ya LLC, Japan.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] Remove ftstc(). It is declared but not implemented.
  2013-06-10  3:03 Masaki Muranaka
@ 2013-06-11 15:29 ` Sascha Hauer
  2013-06-12  5:50   ` Masaki Muranaka
  0 siblings, 1 reply; 8+ messages in thread
From: Sascha Hauer @ 2013-06-11 15:29 UTC (permalink / raw)
  To: Masaki Muranaka; +Cc: barebox

On Mon, Jun 10, 2013 at 12:03:29PM +0900, Masaki Muranaka wrote:
> Signed-off-by: Masaki Muranaka <monaka@monami-ya.jp>

I applied it already.

Sascha

> ---
>  include/stdio.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/stdio.h b/include/stdio.h
> index 5c091a8..ff2572e 100644
> --- a/include/stdio.h
> +++ b/include/stdio.h
> @@ -101,7 +101,6 @@ static inline void putchar(char c)
>  int	fprintf(int file, const char *fmt, ...) __attribute__ ((format(__printf__, 2, 3)));
>  int	fputs(int file, const char *s);
>  int	fputc(int file, const char c);
> -int	ftstc(int file);
>  int	fgetc(int file);
>  
>  #endif /* __STDIO_H */
> -- 
> 1.8.3
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] Remove ftstc(). It is declared but not implemented.
@ 2013-06-10  3:03 Masaki Muranaka
  2013-06-11 15:29 ` Sascha Hauer
  0 siblings, 1 reply; 8+ messages in thread
From: Masaki Muranaka @ 2013-06-10  3:03 UTC (permalink / raw)
  To: barebox

Signed-off-by: Masaki Muranaka <monaka@monami-ya.jp>
---
 include/stdio.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/stdio.h b/include/stdio.h
index 5c091a8..ff2572e 100644
--- a/include/stdio.h
+++ b/include/stdio.h
@@ -101,7 +101,6 @@ static inline void putchar(char c)
 int	fprintf(int file, const char *fmt, ...) __attribute__ ((format(__printf__, 2, 3)));
 int	fputs(int file, const char *s);
 int	fputc(int file, const char c);
-int	ftstc(int file);
 int	fgetc(int file);
 
 #endif /* __STDIO_H */
-- 
1.8.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] Remove ftstc(). It is declared but not implemented.
  2013-06-02 23:02 Masaki Muranaka
@ 2013-06-03  7:16 ` Sascha Hauer
  0 siblings, 0 replies; 8+ messages in thread
From: Sascha Hauer @ 2013-06-03  7:16 UTC (permalink / raw)
  To: Masaki Muranaka; +Cc: barebox

On Mon, Jun 03, 2013 at 08:02:38AM +0900, Masaki Muranaka wrote:
> Signed-off-by: Masaki Muranaka <monaka@monami-ya.jp>

Applied, thanks

Sascha

> ---
>  include/stdio.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/stdio.h b/include/stdio.h
> index 5c091a8..ff2572e 100644
> --- a/include/stdio.h
> +++ b/include/stdio.h
> @@ -101,7 +101,6 @@ static inline void putchar(char c)
>  int	fprintf(int file, const char *fmt, ...) __attribute__ ((format(__printf__, 2, 3)));
>  int	fputs(int file, const char *s);
>  int	fputc(int file, const char c);
> -int	ftstc(int file);
>  int	fgetc(int file);
>  
>  #endif /* __STDIO_H */
> -- 
> 1.8.3
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] Remove ftstc(). It is declared but not implemented.
@ 2013-06-02 23:02 Masaki Muranaka
  2013-06-03  7:16 ` Sascha Hauer
  0 siblings, 1 reply; 8+ messages in thread
From: Masaki Muranaka @ 2013-06-02 23:02 UTC (permalink / raw)
  To: barebox

Signed-off-by: Masaki Muranaka <monaka@monami-ya.jp>
---
 include/stdio.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/stdio.h b/include/stdio.h
index 5c091a8..ff2572e 100644
--- a/include/stdio.h
+++ b/include/stdio.h
@@ -101,7 +101,6 @@ static inline void putchar(char c)
 int	fprintf(int file, const char *fmt, ...) __attribute__ ((format(__printf__, 2, 3)));
 int	fputs(int file, const char *s);
 int	fputc(int file, const char c);
-int	ftstc(int file);
 int	fgetc(int file);
 
 #endif /* __STDIO_H */
-- 
1.8.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-06-12  5:58 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-02 13:14 [PATCH] Remove ftstc(). It is declared but not implemented Masaki Muranaka
2013-06-02 15:47 ` Alexander Shiyan
2013-06-02 23:02   ` Masaki Muranaka
2013-06-02 23:02 Masaki Muranaka
2013-06-03  7:16 ` Sascha Hauer
2013-06-10  3:03 Masaki Muranaka
2013-06-11 15:29 ` Sascha Hauer
2013-06-12  5:50   ` Masaki Muranaka

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox