mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@ingics.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: [PATCH] at91: sama5d3: fix off-by-one array boundary checking for pdata_i2c
Date: Tue, 04 Jun 2013 09:42:21 +0800	[thread overview]
Message-ID: <1370310141.7191.1.camel@phoenix> (raw)

i2c_id is used as array subscript, so it's valid value range is
0 ... ARRAY_SIZE -1.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 arch/arm/mach-at91/sama5d3_devices.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-at91/sama5d3_devices.c b/arch/arm/mach-at91/sama5d3_devices.c
index 031168b..e456bd0 100644
--- a/arch/arm/mach-at91/sama5d3_devices.c
+++ b/arch/arm/mach-at91/sama5d3_devices.c
@@ -322,7 +322,7 @@ void at91_add_device_i2c(short i2c_id, struct i2c_board_info *devices, int nr_de
 {
 	struct i2c_gpio_platform_data *pdata;
 
-	if (i2c_id > ARRAY_SIZE(pdata_i2c))
+	if (i2c_id >= ARRAY_SIZE(pdata_i2c))
 		return;
 
 	i2c_register_board_info(i2c_id, devices, nr_devices);
-- 
1.8.1.2




_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

                 reply	other threads:[~2013-06-04  1:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370310141.7191.1.camel@phoenix \
    --to=axel.lin@ingics.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox