mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] Revert "usb: chipidea-imx: Fix usb initialization"
@ 2013-06-05 13:26 Lucas Stach
  2013-06-05 13:33 ` Alexander Shiyan
  0 siblings, 1 reply; 3+ messages in thread
From: Lucas Stach @ 2013-06-05 13:26 UTC (permalink / raw)
  To: barebox

This breaks HSIC and has no good justification why this would
be needed for ULPI.

This reverts commit 2e7d66f526217f6ff3167e4580aecb9548a0de33.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/usb/imx/chipidea-imx.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/imx/chipidea-imx.c b/drivers/usb/imx/chipidea-imx.c
index 928ebf3..4ee7610 100644
--- a/drivers/usb/imx/chipidea-imx.c
+++ b/drivers/usb/imx/chipidea-imx.c
@@ -148,13 +148,13 @@ static int imx_chipidea_probe(struct device_d *dev)
 	ci->data.post_init = imx_chipidea_port_post_init;
 	ci->data.drvdata = ci;
 
+	imx_chipidea_port_init(ci);
+
 	portsc = readl(base + 0x184);
 	portsc &= ~MXC_EHCI_PORTSC_MASK;
 	portsc |= ci->flags & MXC_EHCI_PORTSC_MASK;
 	writel(portsc, base + 0x184);
 
-	imx_chipidea_port_init(ci);
-
 	if ((ci->flags & MXC_EHCI_PORTSC_MASK) == MXC_EHCI_MODE_ULPI) {
 		dev_dbg(dev, "using ULPI phy\n");
 		if (IS_ENABLED(CONFIG_USB_ULPI)) {
-- 
1.7.10.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-06-05 20:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-05 13:26 [PATCH] Revert "usb: chipidea-imx: Fix usb initialization" Lucas Stach
2013-06-05 13:33 ` Alexander Shiyan
2013-06-05 20:20   ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox