mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM: pcm038: Fix partition size definitions
@ 2013-06-09  8:40 Alexander Shiyan
  2013-06-11 15:26 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Shiyan @ 2013-06-09  8:40 UTC (permalink / raw)
  To: barebox


Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boards/pcm038/pcm038.c | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boards/pcm038/pcm038.c b/arch/arm/boards/pcm038/pcm038.c
index 372aea5..49677c2 100644
--- a/arch/arm/boards/pcm038/pcm038.c
+++ b/arch/arm/boards/pcm038/pcm038.c
@@ -332,22 +332,20 @@ static int pcm038_devices_init(void)
 
 	switch (bootsource_get()) {
 	case BOOTSOURCE_NAND:
-		devfs_add_partition("nand0", 0x00000, 0x80000,
-					DEVFS_PARTITION_FIXED, "self_raw");
+		devfs_add_partition("nand0", 0, SZ_512K,
+				    DEVFS_PARTITION_FIXED, "self_raw");
 		dev_add_bb_dev("self_raw", "self0");
-
-		devfs_add_partition("nand0", 0x80000, 0x100000,
-					DEVFS_PARTITION_FIXED, "env_raw");
+		devfs_add_partition("nand0", SZ_512K, SZ_128K,
+				    DEVFS_PARTITION_FIXED, "env_raw");
 		dev_add_bb_dev("env_raw", "env0");
 		envdev = "NAND";
 		break;
 	default:
-		devfs_add_partition("nor0", 0x00000, 0x80000,
-					DEVFS_PARTITION_FIXED, "self0");
-		devfs_add_partition("nor0", 0x80000, 0x100000,
-					DEVFS_PARTITION_FIXED, "env0");
+		devfs_add_partition("nor0", 0, SZ_512K,
+				    DEVFS_PARTITION_FIXED, "self0");
+		devfs_add_partition("nor0", SZ_512K, SZ_128K,
+				    DEVFS_PARTITION_FIXED, "env0");
 		protect_file("/dev/env0", 1);
-
 		envdev = "NOR";
 	}
 
-- 
1.8.1.5


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: pcm038: Fix partition size definitions
  2013-06-09  8:40 [PATCH] ARM: pcm038: Fix partition size definitions Alexander Shiyan
@ 2013-06-11 15:26 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2013-06-11 15:26 UTC (permalink / raw)
  To: Alexander Shiyan; +Cc: barebox

On Sun, Jun 09, 2013 at 12:40:08PM +0400, Alexander Shiyan wrote:
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>

Applied, though I really had liked some hint what was wrong with the
partition sizes.

Sascha

> ---
>  arch/arm/boards/pcm038/pcm038.c | 18 ++++++++----------
>  1 file changed, 8 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/boards/pcm038/pcm038.c b/arch/arm/boards/pcm038/pcm038.c
> index 372aea5..49677c2 100644
> --- a/arch/arm/boards/pcm038/pcm038.c
> +++ b/arch/arm/boards/pcm038/pcm038.c
> @@ -332,22 +332,20 @@ static int pcm038_devices_init(void)
>  
>  	switch (bootsource_get()) {
>  	case BOOTSOURCE_NAND:
> -		devfs_add_partition("nand0", 0x00000, 0x80000,
> -					DEVFS_PARTITION_FIXED, "self_raw");
> +		devfs_add_partition("nand0", 0, SZ_512K,
> +				    DEVFS_PARTITION_FIXED, "self_raw");
>  		dev_add_bb_dev("self_raw", "self0");
> -
> -		devfs_add_partition("nand0", 0x80000, 0x100000,
> -					DEVFS_PARTITION_FIXED, "env_raw");
> +		devfs_add_partition("nand0", SZ_512K, SZ_128K,
> +				    DEVFS_PARTITION_FIXED, "env_raw");
>  		dev_add_bb_dev("env_raw", "env0");
>  		envdev = "NAND";
>  		break;
>  	default:
> -		devfs_add_partition("nor0", 0x00000, 0x80000,
> -					DEVFS_PARTITION_FIXED, "self0");
> -		devfs_add_partition("nor0", 0x80000, 0x100000,
> -					DEVFS_PARTITION_FIXED, "env0");
> +		devfs_add_partition("nor0", 0, SZ_512K,
> +				    DEVFS_PARTITION_FIXED, "self0");
> +		devfs_add_partition("nor0", SZ_512K, SZ_128K,
> +				    DEVFS_PARTITION_FIXED, "env0");
>  		protect_file("/dev/env0", 1);
> -
>  		envdev = "NOR";
>  	}
>  
> -- 
> 1.8.1.5
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-06-11 15:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-09  8:40 [PATCH] ARM: pcm038: Fix partition size definitions Alexander Shiyan
2013-06-11 15:26 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox