Re: [PATCH v6] omap4-fb: add driver

[Christoph Fritz <chf.fritz@googlemail.com>]

Hi Tomi

On Tue, 2013-06-18 at 10:41 +0300, Tomi Valkeinen wrote:
> On 17/06/13 19:18, Christoph Fritz wrote:
> > This patch adds omap4 display controller support.
> 
> I haven't been following the discussions about this patch, so maybe
> these have been covered:
> 
> OMAP2/3/4/5 all have very similar DSS. Why did you go for omap_4_-fb
> driver, not omap-fb driver?

I'm currently only having an omap4 board here. But I could rename the
driver to the more generic name "omap-fb" and explain in the KCONFIG
that it currently only covers omap4 devices.

So we could go from there up to all other OMAP devices. Okay?

> > +config DRIVER_VIDEO_OMAP4
> > +	bool "OMAP4 framebuffer driver"
> > +	depends on ARCH_OMAP4
> > +	help
> > +	  Add support for the OMAP4 Display Controller.
> > +	  DSI is unsupported, only DISPC parallel mode on LCD2
> > +	  is supported.
> > +
> 
> Also HDMI, RFBI and VENC seem to be unsupported. The DISPC parallel mode
> you mention is MIPI DPI.
> 
> Supporting only the DPI output is "easy", do you have plans to support
> the other outputs and external encoders used in many boards?

No, at present I have no intention to do so.

>  That may
> require a more generic approach, with multiple display "entities" in the
> pipeline. Not that the first version should support that, but I just
> wanted to mention it so that you don't design the driver in too
> non-generic manner.

 Thanks
  -- Christoph



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox