From: "Jan Lübbe" <jlu@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: Re[2]: [PATCH] devfs-core: introduce devfs_append_partition
Date: Wed, 19 Jun 2013 08:32:48 +0200 [thread overview]
Message-ID: <1371623568.4168.71.camel@coredoba.hi.pengutronix.de> (raw)
In-Reply-To: <1371621793.699357681@f89.mail.ru>
On Wed, 2013-06-19 at 10:03 +0400, Alexander Shiyan wrote:
> > On Tue, Jun 18, 2013 at 02:50:50PM +0200, Jan Luebbe wrote:
> > > This simplifies board code for partition setup by keeping track of the
> > > offset.
> > >
> > > Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
> >
> > Good idea. There seem to be some bugs in this area. I'm fine with the
> > patch when some users are converted to this.
>
> But lets make static variable "offset", setup it in devfs_add_partition and
> just add "size" in the devfs_append_partition.
> Otherwise I do not see any difference between "add" and "append".
I'd prefer to have the state where it's obvious to the caller and not in
a static variable somewhere else. :)
Regards,
Jan
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2013-06-19 6:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 12:50 Jan Luebbe
2013-06-19 5:38 ` Sascha Hauer
2013-06-19 6:03 ` Re[2]: " Alexander Shiyan
2013-06-19 6:32 ` Jan Lübbe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371623568.4168.71.camel@coredoba.hi.pengutronix.de \
--to=jlu@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox