mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Teresa Gámez" <t.gamez@phytec.de>
To: barebox@lists.infradead.org
Subject: [PATCHv3 2/4] omap3_spi: Remove CS check in driver
Date: Wed, 19 Jun 2013 09:09:43 +0200	[thread overview]
Message-ID: <1371625785-27704-2-git-send-email-t.gamez@phytec.de> (raw)
In-Reply-To: <1371625785-27704-1-git-send-email-t.gamez@phytec.de>

Board file or DT has to take care that the correct
chip select and bus values are used.

Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
---
changes since v3:
	- splitted the former "omap3_spi: Add CS check for AM335x"
	  patch into two
	- removed the SPI check here

 drivers/spi/omap3_spi.c |    9 ---------
 1 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/drivers/spi/omap3_spi.c b/drivers/spi/omap3_spi.c
index e6581df..508e2d9 100644
--- a/drivers/spi/omap3_spi.c
+++ b/drivers/spi/omap3_spi.c
@@ -327,15 +327,6 @@ static int omap3_spi_setup(struct spi_device *spi)
 {
 	struct spi_master *master = spi->master;
 
-	if (((master->bus_num == 1) && (spi->chip_select > 3)) ||
-			((master->bus_num == 2) && (spi->chip_select > 1)) ||
-			((master->bus_num == 3) && (spi->chip_select > 1)) ||
-			((master->bus_num == 4) && (spi->chip_select > 0))) {
-		printf("SPI error: unsupported chip select %i \
-			on bus %i\n", spi->chip_select, master->bus_num);
-		return -EINVAL;
-	}
-
 	if (spi->max_speed_hz > OMAP3_MCSPI_MAX_FREQ) {
 		printf("SPI error: unsupported frequency %i Hz. \
 			Max frequency is 48 Mhz\n", spi->max_speed_hz);
-- 
1.7.0.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-06-19  7:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-19  7:09 [PATCHv3 1/4] ARM: OMAP: AM33xx: Add muxing function for spi0 Teresa Gámez
2013-06-19  7:09 ` Teresa Gámez [this message]
2013-06-19  7:09 ` [PATCHv3 3/4] omap3_spi: Set the correct CS number for AM33xx Teresa Gámez
2013-06-19  7:09 ` [PATCHv3 4/4] ARM: OMAP: pcm051: Add spi flash support Teresa Gámez
2013-06-19 19:51 ` [PATCHv3 1/4] ARM: OMAP: AM33xx: Add muxing function for spi0 Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371625785-27704-2-git-send-email-t.gamez@phytec.de \
    --to=t.gamez@phytec.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox