mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jan Weitzel <j.weitzel@phytec.de>
To: barebox@lists.infradead.org
Subject: [PATCH v2] OMAP4 do not set TPS62361_REG_ADDR_SET0
Date: Fri, 21 Jun 2013 10:24:02 +0200	[thread overview]
Message-ID: <1371803042-1179-1-git-send-email-j.weitzel@phytec.de> (raw)
In-Reply-To: <CAGo_u6pP9djhzUZyOLNewL4kDwcY0A_KW1ZmdHVurCwBUxBEEg@mail.gmail.com>

Don't set SET0 voltage, because it acts as boot voltage for OPP boot.
Take care that the kernel doesn't drive vset gpio to low. This may
happen while reseting the gpio module at initialization, look for
HWMOD_INIT_NO_RESET.

Signed-off-by: Jan Weitzel <j.weitzel@phytec.de>
Reviewed-by: Nishanth Menon <nm@ti.com>
---
on top of 88796b1
v2: add Reviewed-by

 arch/arm/mach-omap/omap4_generic.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap/omap4_generic.c b/arch/arm/mach-omap/omap4_generic.c
index 7200393..bf1f1a7 100644
--- a/arch/arm/mach-omap/omap4_generic.c
+++ b/arch/arm/mach-omap/omap4_generic.c
@@ -586,11 +586,10 @@ noinline int omap4460_scale_vcores(unsigned vsel0_pin, unsigned volt_mv)
 	writel(0x6026, OMAP44XX_PRM_VC_CFG_I2C_CLK);
 
 	/* TPS - supplies vdd_mpu on 4460
-	 * Setup SET1 and SET0 with right values so that kernel
-	 * can use either of them based on its needs.
+	 * Setup SET1 and don't touch SET0 it acts as boot voltage
+	 * source after reset.
 	 */
 
-	omap4_do_scale_tps62361(TPS62361_REG_ADDR_SET0, volt_mv);
 	omap4_do_scale_tps62361(TPS62361_REG_ADDR_SET1, volt_mv);
 
 	/*
-- 
1.7.0.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-06-21  8:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-12  7:17 [PATCH] " Jan Weitzel
2013-06-12 18:28 ` Nishanth Menon
2013-06-21  8:24   ` Jan Weitzel [this message]
2013-06-23 18:52     ` [PATCH v2] " Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371803042-1179-1-git-send-email-j.weitzel@phytec.de \
    --to=j.weitzel@phytec.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox