* [PATCH] OMAP4 do not set TPS62361_REG_ADDR_SET0
@ 2013-06-12 7:17 Jan Weitzel
2013-06-12 18:28 ` Nishanth Menon
0 siblings, 1 reply; 4+ messages in thread
From: Jan Weitzel @ 2013-06-12 7:17 UTC (permalink / raw)
To: barebox
Don't set SET0 voltage, because it acts as boot voltage for OPP boot.
Take care that the kernel doesn't drive vset gpio to low. This may
happen while reseting the gpio module at initialization, look for
HWMOD_INIT_NO_RESET.
Signed-off-by: Jan Weitzel <j.weitzel@phytec.de>
---
arch/arm/mach-omap/omap4_generic.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap/omap4_generic.c b/arch/arm/mach-omap/omap4_generic.c
index 7200393..bf1f1a7 100644
--- a/arch/arm/mach-omap/omap4_generic.c
+++ b/arch/arm/mach-omap/omap4_generic.c
@@ -586,11 +586,10 @@ noinline int omap4460_scale_vcores(unsigned vsel0_pin, unsigned volt_mv)
writel(0x6026, OMAP44XX_PRM_VC_CFG_I2C_CLK);
/* TPS - supplies vdd_mpu on 4460
- * Setup SET1 and SET0 with right values so that kernel
- * can use either of them based on its needs.
+ * Setup SET1 and don't touch SET0 it acts as boot voltage
+ * source after reset.
*/
- omap4_do_scale_tps62361(TPS62361_REG_ADDR_SET0, volt_mv);
omap4_do_scale_tps62361(TPS62361_REG_ADDR_SET1, volt_mv);
/*
--
1.7.0.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] OMAP4 do not set TPS62361_REG_ADDR_SET0
2013-06-12 7:17 [PATCH] OMAP4 do not set TPS62361_REG_ADDR_SET0 Jan Weitzel
@ 2013-06-12 18:28 ` Nishanth Menon
2013-06-21 8:24 ` [PATCH v2] " Jan Weitzel
0 siblings, 1 reply; 4+ messages in thread
From: Nishanth Menon @ 2013-06-12 18:28 UTC (permalink / raw)
To: Jan Weitzel; +Cc: U-Boot Version 2 (barebox)
On Wed, Jun 12, 2013 at 2:17 AM, Jan Weitzel <j.weitzel@phytec.de> wrote:
> Don't set SET0 voltage, because it acts as boot voltage for OPP boot.
> Take care that the kernel doesn't drive vset gpio to low. This may
> happen while reseting the gpio module at initialization, look for
> HWMOD_INIT_NO_RESET.
>
> Signed-off-by: Jan Weitzel <j.weitzel@phytec.de>
> ---
> arch/arm/mach-omap/omap4_generic.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap/omap4_generic.c b/arch/arm/mach-omap/omap4_generic.c
> index 7200393..bf1f1a7 100644
> --- a/arch/arm/mach-omap/omap4_generic.c
> +++ b/arch/arm/mach-omap/omap4_generic.c
> @@ -586,11 +586,10 @@ noinline int omap4460_scale_vcores(unsigned vsel0_pin, unsigned volt_mv)
> writel(0x6026, OMAP44XX_PRM_VC_CFG_I2C_CLK);
>
> /* TPS - supplies vdd_mpu on 4460
> - * Setup SET1 and SET0 with right values so that kernel
> - * can use either of them based on its needs.
> + * Setup SET1 and don't touch SET0 it acts as boot voltage
> + * source after reset.
> */
>
> - omap4_do_scale_tps62361(TPS62361_REG_ADDR_SET0, volt_mv);
> omap4_do_scale_tps62361(TPS62361_REG_ADDR_SET1, volt_mv);
>
> /*
> --
> 1.7.0.4
Reviewed-by: Nishanth Menon <nm@ti.com>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] OMAP4 do not set TPS62361_REG_ADDR_SET0
2013-06-12 18:28 ` Nishanth Menon
@ 2013-06-21 8:24 ` Jan Weitzel
2013-06-23 18:52 ` Sascha Hauer
0 siblings, 1 reply; 4+ messages in thread
From: Jan Weitzel @ 2013-06-21 8:24 UTC (permalink / raw)
To: barebox
Don't set SET0 voltage, because it acts as boot voltage for OPP boot.
Take care that the kernel doesn't drive vset gpio to low. This may
happen while reseting the gpio module at initialization, look for
HWMOD_INIT_NO_RESET.
Signed-off-by: Jan Weitzel <j.weitzel@phytec.de>
Reviewed-by: Nishanth Menon <nm@ti.com>
---
on top of 88796b1
v2: add Reviewed-by
arch/arm/mach-omap/omap4_generic.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap/omap4_generic.c b/arch/arm/mach-omap/omap4_generic.c
index 7200393..bf1f1a7 100644
--- a/arch/arm/mach-omap/omap4_generic.c
+++ b/arch/arm/mach-omap/omap4_generic.c
@@ -586,11 +586,10 @@ noinline int omap4460_scale_vcores(unsigned vsel0_pin, unsigned volt_mv)
writel(0x6026, OMAP44XX_PRM_VC_CFG_I2C_CLK);
/* TPS - supplies vdd_mpu on 4460
- * Setup SET1 and SET0 with right values so that kernel
- * can use either of them based on its needs.
+ * Setup SET1 and don't touch SET0 it acts as boot voltage
+ * source after reset.
*/
- omap4_do_scale_tps62361(TPS62361_REG_ADDR_SET0, volt_mv);
omap4_do_scale_tps62361(TPS62361_REG_ADDR_SET1, volt_mv);
/*
--
1.7.0.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] OMAP4 do not set TPS62361_REG_ADDR_SET0
2013-06-21 8:24 ` [PATCH v2] " Jan Weitzel
@ 2013-06-23 18:52 ` Sascha Hauer
0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2013-06-23 18:52 UTC (permalink / raw)
To: Jan Weitzel; +Cc: barebox
On Fri, Jun 21, 2013 at 10:24:02AM +0200, Jan Weitzel wrote:
> Don't set SET0 voltage, because it acts as boot voltage for OPP boot.
> Take care that the kernel doesn't drive vset gpio to low. This may
> happen while reseting the gpio module at initialization, look for
> HWMOD_INIT_NO_RESET.
>
> Signed-off-by: Jan Weitzel <j.weitzel@phytec.de>
> Reviewed-by: Nishanth Menon <nm@ti.com>
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-23 18:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-12 7:17 [PATCH] OMAP4 do not set TPS62361_REG_ADDR_SET0 Jan Weitzel
2013-06-12 18:28 ` Nishanth Menon
2013-06-21 8:24 ` [PATCH v2] " Jan Weitzel
2013-06-23 18:52 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox