From: "Eric Bénard" <eric@eukrea.com>
To: barebox@lists.infradead.org
Subject: [PATCH 3/4] video/stm: don't fail when the pixel clock is properly set
Date: Tue, 10 Sep 2013 19:13:33 +0200 [thread overview]
Message-ID: <1378833214-19808-3-git-send-email-eric@eukrea.com> (raw)
In-Reply-To: <1378833214-19808-1-git-send-email-eric@eukrea.com>
the check is wrong as when the clock rate is correctly set
the function will return 0.
Signed-off-by: Eric Bénard <eric@eukrea.com>
---
drivers/video/stm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/stm.c b/drivers/video/stm.c
index 0875c9b..2603129 100644
--- a/drivers/video/stm.c
+++ b/drivers/video/stm.c
@@ -331,7 +331,7 @@ static int stmfb_activate_var(struct fb_info *fb_info)
/** @todo ensure HCLK is active at this point of time! */
size = clk_set_rate(fbi->clk, PICOS2KHZ(mode->pixclock) * 1000);
- if (size == 0) {
+ if (size != 0) {
dev_dbg(fbi->hw_dev, "Unable to set a valid pixel clock\n");
return -EINVAL;
}
--
1.8.3.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-09-10 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 17:13 [PATCH 1/4] mxs_spi: unbreak driver Eric Bénard
2013-09-10 17:13 ` [PATCH 2/4] nand_mxs: fix on i.MX28 Eric Bénard
2013-09-10 17:13 ` Eric Bénard [this message]
2013-09-10 17:13 ` [PATCH 4/4] video/stm: enable clock to get the display working Eric Bénard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378833214-19808-3-git-send-email-eric@eukrea.com \
--to=eric@eukrea.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox