mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <dev@lynxeye.de>
To: "Jan Lübbe" <jlu@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/4] am33xx_generic: convert from switch to if/else
Date: Wed, 02 Oct 2013 22:16:58 +0200	[thread overview]
Message-ID: <1380745018.14068.7.camel@tellur> (raw)
In-Reply-To: <1380744254.7042.6.camel@polaris.local>

Am Mittwoch, den 02.10.2013, 22:04 +0200 schrieb Jan Lübbe:
> On Wed, 2013-10-02 at 21:45 +0200, Lucas Stach wrote: 
> > Am Mittwoch, den 02.10.2013, 21:30 +0200 schrieb Jan Luebbe:
> > > The function am33xx_get_cpu_rev may be called before barebox_arm_entry(),
> > > so we need to avoid switch statements. 
> > 
> > Uhm, could you please be more verbose on _why_ we need to avoid switch
> > statements at this stage? I might be running into the same failure with
> > Tegra at some point if there's a real issue.
> 
> I believe the problem is that the table is accessed using absolute
> addresses. Before the call to barebox_arm_entry() barebox may be running
> at a different address.
> 
Ah, so it's producing a jump table with absolute offsets even for this
rather trivial switch statement? I can see how this would cause issues.
How about using "-fno-jump-tables" for the objects that are referenced
in the early startup code? This may allow you to drop this code
workaround.

Regards,
Lucas



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-10-02 20:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-02 19:30 BeagleBone fixes & cleanup Jan Luebbe
2013-10-02 19:30 ` [PATCH 1/4] am33xx_generic: convert from switch to if/else Jan Luebbe
2013-10-02 19:45   ` Lucas Stach
2013-10-02 20:04     ` Jan Lübbe
2013-10-02 20:16       ` Lucas Stach [this message]
2013-10-02 19:30 ` [PATCH 2/4] arm: mmu: be more verbose if ttb setup fails Jan Luebbe
2013-10-02 19:30 ` [PATCH 3/4] arm: omap: am33xx_generic: fix DDR setup for DDR2 Jan Luebbe
2013-10-02 19:30 ` [PATCH 4/4] beaglebone: use most recent timings for white variant Jan Luebbe
2013-10-06 11:15 ` BeagleBone fixes & cleanup Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380745018.14068.7.camel@tellur \
    --to=dev@lynxeye.de \
    --cc=barebox@lists.infradead.org \
    --cc=jlu@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox