mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: 张忠山 <zzs213@126.com>
To: barebox@lists.infradead.org
Cc: 张忠山 <zzs0213@gmail.com>
Subject: [PATCH] don't scan bbt if CONFIG_NAND_BBT not set
Date: Mon,  4 Nov 2013 11:36:49 +0800	[thread overview]
Message-ID: <1383536209-30382-1-git-send-email-zzs213@126.com> (raw)

From: 张忠山 <zzs0213@gmail.com>

when CONFIG_NAND_BBT not set, chip->scan_bbt is NULL and
NAND_SKIP_BBTSCAN not set. So barebox crashed, this is the message

    ......

    nand: ONFI param page 0 valid
    nand: ONFI flash detected
    nand: NAND device: Manufacturer ID: 0x2c, Chip ID: 0xda (Micron MT29F2G08AAD), 256MiB, page size: 2048, OOB size: 64
    prefetch abort
    pc : [<00000004>]    lr : [<23f0b8d0>]
    sp : 23ffff08  ip : 7fffffff  fp : 00000000
    r10: 04000000  r9 : 00000000  r8 : 00000001
    r7 : 23b637f8  r6 : 00000000  r5 : 23b63ad4  r4 : 23b638b4
    r3 : 00000000  r2 : fffff200  r1 : 0000000a  r0 : 23b63ad4
    Flags: nZCv  IRQs off  FIQs off  Mode SVC_32

may be the best solution is set NAND_SKIP_BBTSCAN somewhere when
CONFIG_NAND_BBT not selected, but I don't known where is the best
position.

Signed-off-by: 张忠山 <zzs0213@gmail.com>
---
 drivers/mtd/nand/nand_base.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index d249565..1dbd5bf 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -3597,8 +3597,12 @@ int nand_scan_tail(struct mtd_info *mtd)
 	if (chip->options & NAND_SKIP_BBTSCAN)
 		return 0;
 
+#ifdef CONFIG_NAND_BBT
 	/* Build bad block table */
 	return chip->scan_bbt(mtd);
+#else
+	return 0;
+#endif
 }
 EXPORT_SYMBOL(nand_scan_tail);
 
-- 
1.7.9.5



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2013-11-04  3:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-04  3:36 张忠山 [this message]
2013-11-04  8:29 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383536209-30382-1-git-send-email-zzs213@126.com \
    --to=zzs213@126.com \
    --cc=barebox@lists.infradead.org \
    --cc=zzs0213@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox