[PATCH 1/6] ARM: at91: Fix signed/unsigned arguments for printf

[PATCH 1/6] ARM: at91: Fix signed/unsigned arguments for printf

[Alexander Shiyan]

"%d" in format string requires a signed integer.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/mach-at91/gpio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-at91/gpio.c b/arch/arm/mach-at91/gpio.c
index b111373..91de85d 100644
--- a/arch/arm/mach-at91/gpio.c
+++ b/arch/arm/mach-at91/gpio.c
@@ -438,7 +438,7 @@ static void at91mux_dump_pio_config(unsigned bank, unsigned pin)
 	void __iomem *pio = at91_gpio->regbase;
 	u32 div;
 
-	printf("pio%c%d configuration\n\n", bank + 'A', pin);
+	printf("pio%c%u configuration\n\n", bank + 'A', pin);
 
 	at91mux_printf_mode(bank, pin);
 	printf("\n");
@@ -499,7 +499,7 @@ static int do_at91mux(int argc, char *argv[])
 	}
 
 	if (pin >= 32) {
-		printf("pin %d >= supported %d pins\n", pin, 32);
+		printf("pin %u >= supported %d pins\n", pin, 32);
 		return 1;
 	}
 
-- 
1.8.1.5


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH] Cleanup Kconfig files

[Alexander Shiyan]

This patch provides a global cleanup barebox Kconfig files. This includes
replacing spaces to tabs, formatting in accordance format.
No functional changes.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/mach-at91/Kconfig    | 1 -
 arch/arm/mach-imx/Kconfig     | 1 -
 arch/arm/mach-omap/Kconfig    | 4 ++--
 arch/ppc/mach-mpc85xx/Kconfig | 8 ++++----
 4 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index 6ab374e..e3eeb2c 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -342,7 +342,6 @@ config MACH_QIL_A9G20
 	  Select this if you are using a Calao Systems QIL-A9G20 Board.
 	  <http://www.calao-systems.com>
 
-
 endchoice
 
 endif
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 973aa37..aa650f8 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -248,7 +248,6 @@ config MACH_IMX21ADS
 	  Say Y here if you are using the Freescale i.MX21ads board equipped
 	  with a Freescale i.MX21 Processor
 
-
 # ----------------------------------------------------------
 
 comment "i.MX25 Boards"
diff --git a/arch/arm/mach-omap/Kconfig b/arch/arm/mach-omap/Kconfig
index b2eec30..42ff384 100644
--- a/arch/arm/mach-omap/Kconfig
+++ b/arch/arm/mach-omap/Kconfig
@@ -95,8 +95,8 @@ config BAREBOX_UPDATE_AM33XX_SPI_NOR_MLO
 	bool
 	depends on BAREBOX_UPDATE
 	help
-          Say Y for barebox update SPI NOR MLO handler.
-          AM35xx, AM33xx chips use big endian MLO for SPI NOR flash.
+	  Say Y for barebox update SPI NOR MLO handler.
+	  AM35xx, AM33xx chips use big endian MLO for SPI NOR flash.
 
 config ARCH_TEXT_BASE
 	hex
diff --git a/arch/ppc/mach-mpc85xx/Kconfig b/arch/ppc/mach-mpc85xx/Kconfig
index 80cb0d9..dc5708c 100644
--- a/arch/ppc/mach-mpc85xx/Kconfig
+++ b/arch/ppc/mach-mpc85xx/Kconfig
@@ -48,10 +48,10 @@ config MPC8544
 	default y
 
 config DDR_SPD
-    bool
-    default y
+	bool
+	default y
 
 config FSL_DDR2
-    bool
-    default y
+	bool
+	default y
 endif
-- 
1.8.1.5


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH] net/Kconfig: Remove non-existent ARCH_DAVINCI

[Alexander Shiyan]

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/net/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 5d7d20f..c626416 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -62,7 +62,7 @@ config DRIVER_NET_SMC91111
 
 config DRIVER_NET_DAVINCI_EMAC
 	bool "TI Davinci/OMAP EMAC ethernet driver"
-	depends on ARCH_DAVINCI || ARCH_OMAP3
+	depends on ARCH_OMAP3
 	select PHYLIB
 
 config DRIVER_NET_DM9K
-- 
1.8.1.5


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 2/6] ARM: mxs: Fix signed/unsigned arguments for printf

[Alexander Shiyan]

"%d" in format string requires a signed integer.
"%u" in format string requires a unsigned integer.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/mach-mxs/bcb.c       | 8 ++++----
 arch/arm/mach-mxs/iomux-imx.c | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/mach-mxs/bcb.c b/arch/arm/mach-mxs/bcb.c
index b5d793e..a7f4ba9 100644
--- a/arch/arm/mach-mxs/bcb.c
+++ b/arch/arm/mach-mxs/bcb.c
@@ -179,7 +179,7 @@ static int calc_bb_offset(struct mtd_info *mtd, struct mx28_fcb *fcb)
 	bb_mark_chunk = bb_mark_offset / chunk_total_size;
 	bb_mark_chunk_offs = bb_mark_offset - (bb_mark_chunk * chunk_total_size);
 	if (bb_mark_chunk_offs > chunk_data_size) {
-		printf("Unsupported ECC layout; BB mark resides in ECC data: %u\n",
+		printf("Unsupported ECC layout; BB mark resides in ECC data: %i\n",
 			bb_mark_chunk_offs);
 		return -EINVAL;
 	}
@@ -267,12 +267,12 @@ static int find_fcb(struct mtd_info *mtd, void *ref, int page)
 	chip->cmdfunc(mtd, NAND_CMD_READ0, 0x00, page);
 	ret = chip->ecc.read_page_raw(mtd, chip, buf, 1, page);
 	if (ret) {
-		printf("Failed to read FCB from page %u: %d\n", page, ret);
+		printf("Failed to read FCB from page %i: %d\n", page, ret);
 		return ret;
 	}
 	chip->select_chip(mtd, -1);
 	if (memcmp(buf, ref, mtd->writesize) == 0) {
-		printf("%s: Found FCB in page %u (%08x)\n", __func__,
+		printf("%s: Found FCB in page %i (%08x)\n", __func__,
 			page, page * mtd->writesize);
 		ret = 1;
 	}
@@ -376,7 +376,7 @@ int update_bcb(int argc, char *argv[])
 
 		ret = write_fcb(mtd, buf, block);
 		if (ret) {
-			printf("Failed to write FCB to block %u\n", block);
+			printf("Failed to write FCB to block %i\n", block);
 			return ret;
 		}
 
diff --git a/arch/arm/mach-mxs/iomux-imx.c b/arch/arm/mach-mxs/iomux-imx.c
index b8b69b3..24295c5 100644
--- a/arch/arm/mach-mxs/iomux-imx.c
+++ b/arch/arm/mach-mxs/iomux-imx.c
@@ -99,7 +99,7 @@ void imx_gpio_mode(uint32_t m)
 
 	/* some pins are disabled when configured for GPIO */
 	if ((gpio_pin > MAX_GPIO_NO) && (GET_FUNC(m) == IS_GPIO)) {
-		printf("Cannot configure pad %d to GPIO\n", gpio_pin);
+		printf("Cannot configure pad %u to GPIO\n", gpio_pin);
 		return;
 	}
 
-- 
1.8.1.5


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 3/6] commands: nandtest: Fix signed/unsigned arguments for printf

[Alexander Shiyan]

"%d" in format string requires a signed integer.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 commands/nandtest.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/commands/nandtest.c b/commands/nandtest.c
index f6e8f99..0da5444 100644
--- a/commands/nandtest.c
+++ b/commands/nandtest.c
@@ -163,8 +163,8 @@ static void print_stats(int nr_passes, int length)
 	for (i = 0; i < MAX_ECC_BITS; i++)
 		printf("ECC %d bit error(s)	: %d\n", i + 1, ecc_stats[i]);
 
-	printf("ECC >%d bit error(s)	: %d\n", MAX_ECC_BITS, ecc_stats_over);
-	printf("ECC corrections failed	: %d\n", ecc_failed_cnt);
+	printf("ECC >%d bit error(s)	: %u\n", MAX_ECC_BITS, ecc_stats_over);
+	printf("ECC corrections failed	: %u\n", ecc_failed_cnt);
 	printf("-------------------------\n");
 }
 
-- 
1.8.1.5


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 4/6] net: netx: Fix signed/unsigned arguments for printf

[Alexander Shiyan]

"%d" in format string requires a signed integer.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/net/netx_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/netx_eth.c b/drivers/net/netx_eth.c
index 9ca9bce..ee3ed23 100644
--- a/drivers/net/netx_eth.c
+++ b/drivers/net/netx_eth.c
@@ -86,7 +86,7 @@ static int netx_eth_send (struct eth_device *edev,
 #endif
 	val = PFIFO_REG( PFIFO_BASE(CON_FIFO_PORT_LO(xcno)) );
 	if((val & FIFO_PTR_ERROR_MASK) & 0x8)
-		printf("error sending frame: %d\n",val);
+		printf("error sending frame: %u\n", val);
 
 	return 0;
 }
-- 
1.8.1.5


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 5/6] gui: Fix signed/unsigned arguments for printf

[Alexander Shiyan]

"%u" in format string requires a unsigned integer.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 lib/gui/png_pico.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/gui/png_pico.c b/lib/gui/png_pico.c
index 393a732..256db35 100644
--- a/lib/gui/png_pico.c
+++ b/lib/gui/png_pico.c
@@ -57,7 +57,7 @@ struct image *png_open(char *inbuf, int insize)
 	png_info = PNG_decode(inbuf, insize);
 
 	if(PNG_error) {
-		printf("error %u:\n", PNG_error);
+		printf("error %i:\n", PNG_error);
 		ret = -EINVAL;
 		goto err;
 	}
-- 
1.8.1.5


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 6/6] imx-usb-loader: Fix signed/unsigned arguments for printf

[Alexander Shiyan]

"%i" in format string requires a signed integer.
"%d" in format string requires a signed integer.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 scripts/imx/imx-usb-loader.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/imx/imx-usb-loader.c b/scripts/imx/imx-usb-loader.c
index 7ccfc99..a2da579 100644
--- a/scripts/imx/imx-usb-loader.c
+++ b/scripts/imx/imx-usb-loader.c
@@ -319,7 +319,7 @@ static int transfer(struct libusb_device_handle *h, int report, unsigned char *p
 						memcpy(p, &tmp[1], *last_trans);
 					}
 				} else {
-					printf("Unexpected report %i err=%i, cnt=%i, last_trans=%i, %02x %02x %02x %02x\n",
+					printf("Unexpected report %i err=%i, cnt=%u, last_trans=%i, %02x %02x %02x %02x\n",
 						tmp[0], err, cnt, *last_trans, tmp[0], tmp[1], tmp[2], tmp[3]);
 					err = 0;
 				}
@@ -468,7 +468,7 @@ static int read_memory(struct libusb_device_handle *h, struct usb_id *p_id,
 		tmp[0] = tmp[1] = tmp[2] = tmp[3] = 0;
 		err = transfer(h, 4, tmp, 64, &last_trans, p_id);
 		if (err) {
-			printf("r4 in err=%i, last_trans=%i  %02x %02x %02x %02x cnt=%d rem=%d\n",
+			printf("r4 in err=%i, last_trans=%i  %02x %02x %02x %02x cnt=%u rem=%d\n",
 					err, last_trans, tmp[0], tmp[1], tmp[2], tmp[3], cnt, rem);
 			break;
 		}
@@ -476,7 +476,7 @@ static int read_memory(struct libusb_device_handle *h, struct usb_id *p_id,
 			if ((last_trans == 64) && (cnt == rem)) {
 				/* Last transfer is expected to be too large for HID */
 			} else {
-				printf("err: %02x %02x %02x %02x cnt=%d rem=%d last_trans=%i\n",
+				printf("err: %02x %02x %02x %02x cnt=%u rem=%d last_trans=%i\n",
 						tmp[0], tmp[1], tmp[2], tmp[3], cnt, rem, last_trans);
 			}
 			last_trans = rem;
@@ -1240,7 +1240,7 @@ static int do_irom_download(struct libusb_device_handle *h, struct usb_id *p_id,
 		}
 	}
 
-	printf("loading binary file(%s) to %08x, skip=0x%x, fsize=%d type=%d...\n",
+	printf("loading binary file(%s) to %08x, skip=0x%x, fsize=%u type=%d...\n",
 			curr->filename, dladdr, skip, fsize, type);
 
 	ret = load_file(h, p_id, p, cnt, buf, BUF_SIZE,
-- 
1.8.1.5


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 1/6] ARM: at91: Fix signed/unsigned arguments for printf

[Sascha Hauer]

On Fri, Nov 08, 2013 at 10:12:52PM +0400, Alexander Shiyan wrote:
> "%d" in format string requires a signed integer.
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>

Applied, thanks.

I like Cleanups ;)

Sascha

> ---
>  arch/arm/mach-at91/gpio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/gpio.c b/arch/arm/mach-at91/gpio.c
> index b111373..91de85d 100644
> --- a/arch/arm/mach-at91/gpio.c
> +++ b/arch/arm/mach-at91/gpio.c
> @@ -438,7 +438,7 @@ static void at91mux_dump_pio_config(unsigned bank, unsigned pin)
>  	void __iomem *pio = at91_gpio->regbase;
>  	u32 div;
>  
> -	printf("pio%c%d configuration\n\n", bank + 'A', pin);
> +	printf("pio%c%u configuration\n\n", bank + 'A', pin);
>  
>  	at91mux_printf_mode(bank, pin);
>  	printf("\n");
> @@ -499,7 +499,7 @@ static int do_at91mux(int argc, char *argv[])
>  	}
>  
>  	if (pin >= 32) {
> -		printf("pin %d >= supported %d pins\n", pin, 32);
> +		printf("pin %u >= supported %d pins\n", pin, 32);
>  		return 1;
>  	}
>  
> -- 
> 1.8.1.5
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox