From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VtfQ3-0003pT-NR for barebox@lists.infradead.org; Thu, 19 Dec 2013 15:21:48 +0000 From: Sascha Hauer Date: Thu, 19 Dec 2013 16:21:23 +0100 Message-Id: <1387466483-16353-1-git-send-email-s.hauer@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH] mtd: fix wrong return values in cdev read To: barebox@lists.infradead.org mtd->read returns the number of bitflips as positive numbers. Instead of returning these numbers Return -EUCLEAN when the bitflip threshold has been reached, 0 otherwise. Signed-off-by: Sascha Hauer --- drivers/mtd/core.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/mtd/core.c b/drivers/mtd/core.c index f63b10e..57b0fad 100644 --- a/drivers/mtd/core.c +++ b/drivers/mtd/core.c @@ -74,12 +74,11 @@ static ssize_t mtd_op_read(struct cdev *cdev, void* buf, size_t count, offset, count); ret = mtd_read(mtd, offset, count, &retlen, buf); - - if(ret) { - printf("err %d\n", ret); + if (ret < 0) return ret; - } - return retlen; + if (mtd->ecc_strength == 0) + return 0; /* device lacks ecc */ + return ret >= mtd->bitflip_threshold ? -EUCLEAN : 0; } #define NOTALIGNED(x) (x & (mtd->writesize - 1)) != 0 -- 1.8.5.1 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox