mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/7] tegra: add break to switch statements
Date: Mon, 17 Feb 2014 13:55:10 +0100	[thread overview]
Message-ID: <1392641710.4634.2.camel@weser.hi.pengutronix.de> (raw)
In-Reply-To: <20140217065359.GH17250@pengutronix.de>

Am Montag, den 17.02.2014, 07:53 +0100 schrieb Sascha Hauer:
> On Thu, Feb 13, 2014 at 11:32:46PM +0100, Lucas Stach wrote:
> > Avoids a possible miscompilation.
> > 
> > Signed-off-by: Lucas Stach <dev@lynxeye.de>
> > ---
> >  arch/arm/mach-tegra/include/mach/lowlevel.h | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/arch/arm/mach-tegra/include/mach/lowlevel.h b/arch/arm/mach-tegra/include/mach/lowlevel.h
> > index 472348a..9081b1c 100644
> > --- a/arch/arm/mach-tegra/include/mach/lowlevel.h
> > +++ b/arch/arm/mach-tegra/include/mach/lowlevel.h
> > @@ -73,8 +73,10 @@ enum tegra_chiptype tegra_get_chiptype(void)
> >  	switch ((hidrev & HIDREV_CHIPID_MASK) >> HIDREV_CHIPID_SHIFT) {
> >  	case 0x20:
> >  		return TEGRA20;
> > +		break;
> >  	default:
> >  		return TEGRA_UNK_REV;
> > +		break;
> 
> What kind of miscompilation other than a compiler bug are you thinking
> of? Have you seen that this patch changes anything?
> 

I have to admit that I haven't investigated the issue closely, but this
actually makes the difference between working and nonworking when adding
in the Tegra3 case later on.

-- 
Pengutronix e.K.                           | Lucas Stach                 |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-02-17 12:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 22:32 [PATCH 0/7] Lowlevel Tegra3 support Lucas Stach
2014-02-13 22:32 ` [PATCH 1/7] tegra: add -fno-jump-tables to lowlevel code Lucas Stach
2014-02-13 22:32 ` [PATCH 2/7] tegra: add break to switch statements Lucas Stach
2014-02-17  6:53   ` Sascha Hauer
2014-02-17 12:55     ` Lucas Stach [this message]
2014-02-13 22:32 ` [PATCH 3/7] tegra: add lowlevel delay function Lucas Stach
2014-02-13 22:32 ` [PATCH 4/7] tegra: add Tegra3 to relevant lowlevel functions Lucas Stach
2014-02-13 22:32 ` [PATCH 5/7] tegra: add lowlevel DVC Lucas Stach
2014-02-17  6:55   ` Sascha Hauer
2014-02-13 22:32 ` [PATCH 6/7] tegra: set AHB clock rate early Lucas Stach
2014-02-13 22:32 ` [PATCH 7/7] tegra: add Tegra3 startup Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392641710.4634.2.camel@weser.hi.pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox