[PATCH] splash: Print error message when no renderer is found

[PATCH] splash: Print error message when no renderer is found

[Sascha Hauer]

the splash command silently fails when no renderer is found for
an image type. Print an error message in this case.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 lib/gui/image_renderer.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/gui/image_renderer.c b/lib/gui/image_renderer.c
index 78e5777..9c92983 100644
--- a/lib/gui/image_renderer.c
+++ b/lib/gui/image_renderer.c
@@ -23,6 +23,8 @@ static struct image_renderer *get_renderer(void* buf, size_t bufsize)
 			return ir;
 	}
 
+	printf("No renderer found for filetype %s\n", file_type_to_string(type));
+
 	return NULL;
 }
 
-- 
1.9.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [SPAM] [PATCH] splash: Print error message when no renderer is found

[Jean-Christophe PLAGNIOL-VILLARD]

On 11:11 Fri 14 Mar     , Sascha Hauer wrote:
> the splash command silently fails when no renderer is found for
> an image type. Print an error message in this case.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  lib/gui/image_renderer.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/gui/image_renderer.c b/lib/gui/image_renderer.c
> index 78e5777..9c92983 100644
> --- a/lib/gui/image_renderer.c
> +++ b/lib/gui/image_renderer.c
> @@ -23,6 +23,8 @@ static struct image_renderer *get_renderer(void* buf, size_t bufsize)
>  			return ir;
>  	}
>  
> +	printf("No renderer found for filetype %s\n", file_type_to_string(type));

	eprintf?
> +
>  	return NULL;
>  }
>  
> -- 
> 1.9.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [SPAM] [PATCH] splash: Print error message when no renderer is found

[Sascha Hauer]

On Fri, Mar 14, 2014 at 06:11:16PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 11:11 Fri 14 Mar     , Sascha Hauer wrote:
> > the splash command silently fails when no renderer is found for
> > an image type. Print an error message in this case.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> >  lib/gui/image_renderer.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/lib/gui/image_renderer.c b/lib/gui/image_renderer.c
> > index 78e5777..9c92983 100644
> > --- a/lib/gui/image_renderer.c
> > +++ b/lib/gui/image_renderer.c
> > @@ -23,6 +23,8 @@ static struct image_renderer *get_renderer(void* buf, size_t bufsize)
> >  			return ir;
> >  	}
> >  
> > +	printf("No renderer found for filetype %s\n", file_type_to_string(type));
> 
> 	eprintf?

ok

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox