mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] of_gpio: return error if no device found
@ 2014-04-09 20:26 Sascha Hauer
  0 siblings, 0 replies; only message in thread
From: Sascha Hauer @ 2014-04-09 20:26 UTC (permalink / raw)
  To: barebox

of_get_named_gpio_flags used to return 'ret' when no device
is found, but 'ret' is zero here. Return an error instead.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/of/of_gpio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/of/of_gpio.c b/drivers/of/of_gpio.c
index 1370d8f..6738a22 100644
--- a/drivers/of/of_gpio.c
+++ b/drivers/of/of_gpio.c
@@ -32,9 +32,9 @@ int of_get_named_gpio_flags(struct device_node *np, const char *propname,
 
 	dev = of_find_device_by_node(out_args.np);
 	if (!dev) {
-		pr_err("%s: unable to find device of node %s: %d\n",
-			__func__, out_args.np->full_name, ret);
-		return ret;
+		pr_err("%s: unable to find device of node %s\n",
+			__func__, out_args.np->full_name);
+		return -ENODEV;
 	}
 
 	ret = gpio_get_num(dev, out_args.args[0]);
-- 
1.9.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-04-09 20:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-09 20:26 [PATCH] of_gpio: return error if no device found Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox