[PATCH] commands: loady: fix Y-Modem/G option name in help message

[PATCH] commands: loady: fix Y-Modem/G option name in help message

[Antony Pavlov]

Actually loady command uses '-g' option for Y-Modem/G mode
selection; see loady() function:

    while ((opt = getopt(argc, argv, "b:t:g")) > 0) {
        switch (opt) {
    ...
        case 'g':
            is_ymodemg = 1;
            break;

By mistake help message show '-y' option for Y-Modem/G mode
selection.

This patch fixes the problem.

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 commands/loadxy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/loadxy.c b/commands/loadxy.c
index 7a91286..93a423c 100644
--- a/commands/loadxy.c
+++ b/commands/loadxy.c
@@ -241,7 +241,7 @@ BAREBOX_CMD_END
 
 static const __maybe_unused char cmd_loady_help[] =
 	"[OPTIONS]\n"
-	"  -y        - use Y-Modem/G (only for lossless tty as USB)\n"
+	"  -g        - use Y-Modem/G (only for lossless tty as USB)\n"
 	"  -t name   - console device name to use - defaults to current console\n"
 	"  -b baud   - baudrate at which to download - defaults to console baudrate\n";
 
-- 
1.9.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] commands: loady: fix Y-Modem/G option name in help message

[Sascha Hauer]

On Tue, Apr 15, 2014 at 01:59:18PM +0400, Antony Pavlov wrote:
> Actually loady command uses '-g' option for Y-Modem/G mode
> selection; see loady() function:
> 
>     while ((opt = getopt(argc, argv, "b:t:g")) > 0) {
>         switch (opt) {
>     ...
>         case 'g':
>             is_ymodemg = 1;
>             break;
> 
> By mistake help message show '-y' option for Y-Modem/G mode
> selection.
> 
> This patch fixes the problem.
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>

Applied, thanks

Sascha

> ---
>  commands/loadxy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/commands/loadxy.c b/commands/loadxy.c
> index 7a91286..93a423c 100644
> --- a/commands/loadxy.c
> +++ b/commands/loadxy.c
> @@ -241,7 +241,7 @@ BAREBOX_CMD_END
>  
>  static const __maybe_unused char cmd_loady_help[] =
>  	"[OPTIONS]\n"
> -	"  -y        - use Y-Modem/G (only for lossless tty as USB)\n"
> +	"  -g        - use Y-Modem/G (only for lossless tty as USB)\n"
>  	"  -t name   - console device name to use - defaults to current console\n"
>  	"  -b baud   - baudrate at which to download - defaults to console baudrate\n";
>  
> -- 
> 1.9.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox