From: Lucas Stach <dev@lynxeye.de>
To: barebox@lists.infradead.org
Subject: [PATCH v2 2/2] commands: uimage: remove redundant error message
Date: Mon, 21 Apr 2014 15:50:35 +0200 [thread overview]
Message-ID: <1398088235-13933-2-git-send-email-dev@lynxeye.de> (raw)
In-Reply-To: <1398088235-13933-1-git-send-email-dev@lynxeye.de>
uimage_verify already prints an error message if the CRC
is wrong. Romove the never reached redundant message in
the caller.
Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
commands/uimage.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/commands/uimage.c b/commands/uimage.c
index 345e49600c81..bdc74448d9e5 100644
--- a/commands/uimage.c
+++ b/commands/uimage.c
@@ -62,12 +62,9 @@ static int do_uimage(int argc, char *argv[])
if (verify) {
printf("verifying data crc... ");
ret = uimage_verify(handle);
- if (ret) {
+ if (ret)
goto err;
- printf("Bad Data CRC\n");
- } else {
- printf("ok\n");
- }
+ printf("ok\n");
}
if (extract) {
--
1.9.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-04-21 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 13:50 [PATCH v2 1/2] don't cast negative error codes to unsigned size_t Lucas Stach
2014-04-21 13:50 ` Lucas Stach [this message]
2014-04-23 7:21 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398088235-13933-2-git-send-email-dev@lynxeye.de \
--to=dev@lynxeye.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox