From: Juergen Borleis <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 1/3] net/ifup.c: don't fail silently
Date: Wed, 23 Apr 2014 11:19:24 +0200 [thread overview]
Message-ID: <1398244766-5843-2-git-send-email-jbe@pengutronix.de> (raw)
In-Reply-To: <1398244766-5843-1-git-send-email-jbe@pengutronix.de>
Since commit a162dfe50345d3461010759f8a0e79f7e388c140 the ifup command is implemented in C and runs up to two external scripts.
If one of these scripts return with an error code, the command terminates silently. This can confuse a user because there is
no hint about the reason why it fails. Add error messages to avoid this case.
Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
---
net/ifup.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/net/ifup.c b/net/ifup.c
index 7b63136..c74120c 100644
--- a/net/ifup.c
+++ b/net/ifup.c
@@ -70,14 +70,18 @@ int ifup(const char *name, unsigned flags)
cmd_discover = asprintf("/env/network/%s-discover", name);
ret = run_command(cmd);
- if (ret)
+ if (ret) {
+ pr_err("Running '%s' fails\n", cmd);
goto out;
+ }
ret = stat(cmd_discover, &s);
if (!ret) {
ret = run_command(cmd_discover);
- if (ret)
+ if (ret) {
+ pr_err("Running '%s' fails\n", cmd);
goto out;
+ }
}
dev = get_device_by_name(name);
--
1.9.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-04-23 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 9:19 Fix some ifup related network issues Juergen Borleis
2014-04-23 9:19 ` Juergen Borleis [this message]
2014-04-23 10:30 ` [PATCH 1/3] net/ifup.c: don't fail silently Sascha Hauer
2014-04-23 10:56 ` Juergen Borleis
2014-04-23 9:19 ` [PATCH 2/3] net/ifup.c: avoid setting the MAC twice Juergen Borleis
2014-04-23 9:19 ` [PATCH 3/3] default environment: force a specific return value Juergen Borleis
2014-04-24 7:04 ` Fix some ifup related network issues Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398244766-5843-2-git-send-email-jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox