mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Juergen Borleis <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 2/3] net/ifup.c: avoid setting the MAC twice
Date: Wed, 23 Apr 2014 11:19:25 +0200	[thread overview]
Message-ID: <1398244766-5843-3-git-send-email-jbe@pengutronix.de> (raw)
In-Reply-To: <1398244766-5843-1-git-send-email-jbe@pengutronix.de>

The command always sets the MAC address of the interface in the code path.
For the static network configuration case it sets it again, due to the
environment variable keyword ("ethaddr") is listed again in the table.
Remove this keyword from the table, because the MAC is already set.

Signed-off-by: Juergen Borleis <jbe@pengutronix.de>
---
 net/ifup.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/ifup.c b/net/ifup.c
index c74120c..3216ce7 100644
--- a/net/ifup.c
+++ b/net/ifup.c
@@ -31,7 +31,6 @@ static char *vars[] = {
 	"netmask",
 	"gateway",
 	"serverip",
-	"ethaddr",
 };
 
 static int eth_set_param(struct device_d *dev, const char *param)
-- 
1.9.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2014-04-23  9:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-23  9:19 Fix some ifup related network issues Juergen Borleis
2014-04-23  9:19 ` [PATCH 1/3] net/ifup.c: don't fail silently Juergen Borleis
2014-04-23 10:30   ` Sascha Hauer
2014-04-23 10:56     ` Juergen Borleis
2014-04-23  9:19 ` Juergen Borleis [this message]
2014-04-23  9:19 ` [PATCH 3/3] default environment: force a specific return value Juergen Borleis
2014-04-24  7:04 ` Fix some ifup related network issues Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398244766-5843-3-git-send-email-jbe@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox