mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Shiyan <shc_work@mail.ru>
To: barebox@lists.infradead.org
Subject: [PATCH 2/2] commands/umount: Return real error code if "umount" fail
Date: Sat, 26 Apr 2014 14:40:10 +0400	[thread overview]
Message-ID: <1398508810-19974-2-git-send-email-shc_work@mail.ru> (raw)
In-Reply-To: <1398508810-19974-1-git-send-email-shc_work@mail.ru>

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 commands/umount.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/commands/umount.c b/commands/umount.c
index e6de1bc..f0f9fce 100644
--- a/commands/umount.c
+++ b/commands/umount.c
@@ -23,16 +23,10 @@
 
 static int do_umount(int argc, char *argv[])
 {
-	int ret = 0;
-
 	if (argc != 2)
 		return COMMAND_ERROR_USAGE;
 
-	if ((ret = umount(argv[1]))) {
-		perror("umount");
-		return 1;
-	}
-	return 0;
+	return umount(argv[1]);
 }
 
 static const __maybe_unused char cmd_umount_help[] =
-- 
1.8.3.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-04-26 10:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-26 10:40 [PATCH 1/2] commands/mount: Return real error code if "mount" fail Alexander Shiyan
2014-04-26 10:40 ` Alexander Shiyan [this message]
2014-04-27  6:42 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398508810-19974-2-git-send-email-shc_work@mail.ru \
    --to=shc_work@mail.ru \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox