From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.phytec.de ([217.6.246.34] helo=root.phytec.de) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wem58-0001tN-Fl for barebox@lists.infradead.org; Mon, 28 Apr 2014 13:58:55 +0000 From: Christian Hemp In-Reply-To: <1398431808.4657.35.camel@weser.hi.pengutronix.de> References: <1398426868-30285-1-git-send-email-c.hemp@phytec.de> <1398426868-30285-4-git-send-email-c.hemp@phytec.de> <20140425130834.GA29115@omega> <1398431808.4657.35.camel@weser.hi.pengutronix.de> Date: Mon, 28 Apr 2014 15:58:21 +0200 Message-ID: <1398693501.5448.25.camel@lws-hemp> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 4/4] imx6: Add support for phyCARD-i.MX6 To: Lucas Stach Cc: barebox@lists.infradead.org Hi, Am Freitag, den 25.04.2014, 15:16 +0200 schrieb Lucas Stach: > Am Freitag, den 25.04.2014, 15:10 +0200 schrieb Alexander Aring: > > Hi, > > > > On Fri, Apr 25, 2014 at 01:54:28PM +0200, Christian Hemp wrote: > > > Add support for Phytec phyCARD-i.MX6. > > > - 1GB RAM on two banks > > > - 1GB RAM on one bank > > > - 2GB RAM on two banks > > ... > > > + > > > +extern char __dtb_imx6q_phytec_pbaa03_start[]; > > > + > > > +ENTRY_FUNCTION(start_phytec_pbaa03_1gib, r0, r1, r2) > > > +{ > > > + uint32_t fdt; > > > + > > > + arm_cpu_lowlevel_init(); > > > + > > > + arm_setup_stack(0x00920000 - 8); > > > + > > > + if (IS_ENABLED(CONFIG_DEBUG_LL)) > > > + setup_uart(); > > > + > > > + fdt = (uint32_t)__dtb_imx6q_phytec_pbaa03_start - get_runtime_offset(); > > > + > > > + barebox_arm_entry(0x10000000, SZ_1G, fdt); > > > +} > > > + > > > +ENTRY_FUNCTION(start_phytec_pbaa03_1gib_1bank, r0, r1, r2) > > > +{ > > > + uint32_t fdt; > > > + > > > + arm_cpu_lowlevel_init(); > > > + > > > + arm_setup_stack(0x00920000 - 8); > > > + > > > + if (IS_ENABLED(CONFIG_DEBUG_LL)) > > > + setup_uart(); > > > + > > > + fdt = (uint32_t)__dtb_imx6q_phytec_pbaa03_start - get_runtime_offset(); > > > + > > > + barebox_arm_entry(0x10000000, SZ_1G, fdt); > > > +} > > > + > > > > Don't see a difference between start_phytec_pbaa03_1gib_1bank and > > start_phytec_pbaa03_1gib. Maybe you can write a new function and these > > two functions can call this function... > > > > It's a design question... > > > If those two are really meant to be the same, you don't even need two > entry functions. Just build a single PBL and add different DCDs through > the image mechanism. I tried it with one entry function but I get no positive result. The only two results I get was, wrong memory initialization and a build error. What do I need to change in the following lines to use a single PBL and different DCDs for both memory versions? pblx-$(CONFIG_MACH_PCAAXL3) += start_phytec_pbaa03_1gib CFG_start_phytec_pbaa03_1gib.pblx.imximg = $(board)/phytec-phycard-imx6/flash-header-phytec-pcaaxl3-1gib.imxcfg FILE_barebox-phytec-pbaa03-1gib.img = start_phytec_pbaa03_1gib.pblx.imximg image-$(CONFIG_MACH_PCAAXL3) += barebox-phytec-pbaa03-1gib.img pblx-$(CONFIG_MACH_PCAAXL3) += start_phytec_pbaa03_1gib_1bank CFG_start_phytec_pbaa03_1gib_1bank.pblx.imximg = $(board)/phytec-phycard-imx6/flash-header-phytec-pcaaxl3-1gib-1bank.imxcfg FILE_barebox-phytec-pbaa03-1gib-1bank.img = start_phytec_pbaa03_1gib_1bank.pblx.imximg image-$(CONFIG_MACH_PCAAXL3) += barebox-phytec-pbaa03-1gib-1bank.img Regards, Christian > > Regards, > Lucas _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox