mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Christian Hemp" <c.hemp@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] imx6: Add support for phyCARD-i.MX6
Date: Wed, 30 Apr 2014 15:15:29 +0400	[thread overview]
Message-ID: <1398856529.154234152@f68.i.mail.ru> (raw)
In-Reply-To: <1398848852-29093-1-git-send-email-c.hemp@phytec.de>

Wed, 30 Apr 2014 11:07:32 +0200 от Christian Hemp <c.hemp@phytec.de>:
> Add support for Phytec phyCARD-i.MX6.
> 	- 1GB RAM on two banks
> 	- 1GB RAM on one bank
> 	- 2GB RAM on two banks
> 
> Signed-off-by: Christian Hemp <c.hemp@phytec.de>
...
> +static int phytec_pcaaxl3_core_init(void)
> +{
> +	if (!of_machine_is_compatible("phytec,imx6q-pcaaxl3"))
> +		return 0;
> +
> +	imx6_init_lowlevel();
> +
> +	return 0;
> +}

This can be easy:
if (of_machine_is_compatible("phytec,imx6q-pcaaxl3"))
  imx6_init_lowlevel();
return 0;

...
> +++ b/arch/arm/boards/phytec-phycard-imx6/lowlevel.c
...
> +static inline void setup_uart(void)
> +{
> +	void __iomem *ccmbase = (void *)MX6_CCM_BASE_ADDR;

= IOMEM(MX6_CCM_BASE_ADDR);
and so on...

...
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 58dc38b..63fe854 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -27,7 +27,8 @@ dtb-$(CONFIG_ARCH_IMX6) += imx6q-gk802.dtb \
>  	imx6q-nitrogen6x.dtb \
>  	imx6dl-nitrogen6x.dtb \
>  	imx6q-udoo.dtb \
> -	imx6q-var-custom.dtb
> +	imx6q-var-custom.dtb \

Let's use *-bb.dtb as other boards.

---

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2014-04-30 11:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30  9:07 Christian Hemp
2014-04-30  9:35 ` Antony Pavlov
2014-04-30 11:15 ` Alexander Shiyan [this message]
2014-04-30 12:52   ` Sascha Hauer
2014-04-30 12:55     ` Alexander Shiyan
2014-04-30 13:03       ` Sascha Hauer
2014-04-30 13:07         ` Alexander Shiyan
2014-04-30 13:20           ` Sascha Hauer
2014-04-30 14:15     ` Christian Hemp
2014-04-30 17:46       ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398856529.154234152@f68.i.mail.ru \
    --to=shc_work@mail.ru \
    --cc=barebox@lists.infradead.org \
    --cc=c.hemp@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox